Commit Graph

512 Commits

Author SHA1 Message Date
nathan
df489f14df Leave output buffering alone, since trying to turn it off makes the download fail
The browser was giving "Failed - Network error" and there was nothing in the server log. ob_get_level() was giving 3, but trying to turn it using ob_end_clean() was just... failing.
2022-04-20 09:45:58 -06:00
ralf
510dbefce8 fix PHP 8.0 Error: explode(): Argument ($string) must be of type string, array given 2022-04-06 16:30:01 +03:00
Ralf Becker
e05ae9ad82 fix explode(): Argument ($string) must be of type string, array given 2022-01-06 19:11:42 +02:00
Ralf Becker
dd73884534 fix PHP 8.0 Error: Illegal string offset 'string' 2021-11-23 17:17:48 +01:00
Ralf Becker
e2f06d0b94 fix PHP 8.0 TypeError: count(): Argument ($value) must be of type Countable|array, bool given 2021-11-23 08:41:16 +01:00
Ralf Becker
76e4a2acd3 fix PHP 8.0 TypeError: Unsupported operand types: string + string 2021-11-22 08:41:01 +01:00
Ralf Becker
dd74e87a0c fix PHP 8.0 TypeError: implode(): Argument ($pieces) must be of type array, string given 2021-11-22 08:36:55 +01:00
nathan
bcb2c6fd91 Fix PHP 8.0 TypeError: get_class(): Argument ($object) must be of type object, null given
Also fix some deprecated implode() calls
2021-11-16 09:24:33 -07:00
Ralf Becker
03a9c7efe2 fix PHP 8.0 TypeError: implode(): Argument ($array) must be of type ?array, string given 2021-11-16 08:40:43 +01:00
Ralf Becker
39c93ac9ca fix PHP 8.0 ValueError: fgetcsv(): Argument ($separator) must be a single character 2021-11-16 08:37:54 +01:00
Ralf Becker
9409649684 fix PHP 8.0 ValueError: Path cannot be empty
and other IDE errors
2021-11-16 08:17:56 +01:00
Ralf Becker
607526774f fix PHP 8.0 Error: Undefined constant "self" 2021-11-15 15:55:39 +01:00
Ralf Becker
3dd7af4aa5 fix diverse PHP 8.0 TypeErrors and ArgumentCountError in import/export 2021-11-15 14:41:36 +01:00
Ralf Becker
3da9840ca9 fix PHP 8.0 TypeError: array_keys(): Argument ($array) must be of type array, null given 2021-11-15 08:02:58 +01:00
Ralf Becker
f4a8b56680 fix PHP 8.0 TypeError: count(): Argument ($value) must be of type Countable|array, null given 2021-11-14 15:48:18 +01:00
Ralf Becker
38aec8c19e fix PHP 8.0 TypeError: count(): Argument ($value) must be of type Countable|array, null given 2021-11-14 15:37:46 +01:00
Ralf Becker
12a77b2126 fix PHP 8.0 TypeError: Api\Accounts::username(): Argument ($account_id) must be of type ?int, string given
using Api\Accounts::title() but cast to int, if giving an non-zero result
2021-11-08 12:34:34 +01:00
nathan
6cd8f67985 Try to avoid "PHP Warning: DOMDocument::loadXML(): Empty string supplied as input" 2021-11-03 09:30:58 -06:00
Ralf Becker
b1af39be37 fix big chunk of PHP 8.0 warnings 2021-10-21 10:39:57 +02:00
Ralf Becker
310984722f fix PHP 8.0 error: count(): Argument ($value) must be of type Countable|array, string given 2021-10-19 09:03:29 +02:00
nathan
c8843f88c9 Fix PHP 8 error: "array_search(): Argument ($haystack) must be of type array, null given" 2021-10-14 08:55:57 -06:00
nathan
f6f5fccd08 Avoid some more PHP8 errors
An error happened! (TypeError): Cannot access offset of type string on string
2021-10-13 15:34:32 -06:00
nathan
4fdefd61ae PHP 8.0: Avoid fatal error "array_key_exists(): Argument ($array) must be of type array, null given" 2021-10-13 09:55:51 -06:00
Ralf Becker
6d4de34749 fix PHP 8.0 TypeError: count(): Argument ($value) must be of type Countable|array, null given 2021-10-11 12:43:20 +02:00
nathangray
7ce92b9124 Import/Export: Avoid "Undefined variable: filter" error
Correct files this time

(cherry picked from commit a7d52168b7)
2021-06-11 13:17:52 -06:00
nathangray
5ec39458af Revert "Import/Export: Avoid "Undefined variable: filter" error"
This reverts commit d57df627

(cherry picked from commit c853bb0f84)
2021-06-11 13:17:50 -06:00
nathangray
1586bbd66a Import/Export: Avoid "Undefined variable: filter" error
(cherry picked from commit d57df627a7)
2021-06-11 13:17:47 -06:00
nathangray
5a54397c46 Importexport: Improve handling of targets
- Give error if target uses an unknown stream wrapper
- If stream wrapper is not provided, assume VFS

(cherry picked from commit 93e2633107)
2021-06-11 13:17:39 -06:00
nathangray
aa241edfb3 Import/Export: Improve error message from bad XML
(cherry picked from commit dd545799e0)
2021-06-11 13:17:30 -06:00
nathangray
883eb9132d Importexport: Fix import category from file was always blank 2021-04-22 14:28:57 -06:00
nathangray
145b7efca2 Importexport: Fix clicking import button from list did not start with that definition loaded 2021-04-22 14:28:19 -06:00
nathangray
aff06ec4cc Import/export fixes
- Fix for missing floats by Jürgen Dlugi
- Fix broken timesheet export was always 0 results
2021-04-08 16:53:06 -06:00
nathangray
98219a2517 Put type in front of variable name 2021-03-31 13:14:18 -06:00
nathangray
a21c49d99c PHP 8 code quality improvements suggested by PHPStorm 2021-03-31 11:25:12 -06:00
Ralf Becker
868135775c PHP 8 fixes 2021-03-29 16:47:19 +02:00
Ralf Becker
ab9c089f70 fix PHP 8 Fatal error Array and string offset access syntax with curly braces is no longer supported 2021-03-21 21:13:07 +01:00
nathangray
947755676e ImportExport: Another fix for exporting custom date fields with custom format.
- PHP base DateTime class was being used instead of our own Api\DateTime
- User's preferred date format was not being respected
- Custom formatting was only parsed if the first entry had a value in that field
2020-09-18 10:06:04 -06:00
nathangray
edaf3abd4f ImportExport: Fix custom dates formatting to work for more than just the first row 2020-09-10 11:39:25 -06:00
nathangray
3c4d46b030 ImportExport: Fix date-time customfields with custom format were not exported correctly
see 74bd66d857
2020-09-04 11:06:25 -06:00
nathangray
74bd66d857 * ImportExport: Date custom fields with custom formatting now correctly handled 2020-09-03 11:29:55 -06:00
nathangray
bc253e0bd7 ImportExport: Fix all custom field types were showing up as filterable. Now limited to the ones we can handle. 2020-07-10 11:25:49 -06:00
nathangray
1a3582536a Import/Export: Fix export destroyed list's etemplate request 2020-07-09 13:14:24 -06:00
nathangray
aba5f61a42 Fix missing translation reported by Stefan Unverricht 2020-04-15 10:15:24 -06:00
nathangray
d31d19c1ec * Import/Export: Fix export CSV with Tab delimiter literally inserted '\t' instead of tab.
Reported by xenolevis
2019-10-02 11:48:10 -06:00
nathangray
11e145967e Remove unused preferred export definition preference 2019-08-02 10:17:16 -06:00
nathangray
196cd13771 Importexport - support deleteaccount hook 2019-07-22 15:11:09 -06:00
nathangray
94798bb691 Import/Export - fix definition list actions (Create export) disappeared from context menu after use 2019-07-08 13:49:16 -06:00
nathangray
fdddeb1e84 ImportExport - fix create export from import fails with error
"Too few arguments to function importexport_definitions_ui::save(), 0 passed..."
2019-06-24 09:35:11 -06:00
nathangray
e71bbd8abe Store requester and comment into command history when importing users 2019-05-10 13:33:04 -06:00
nathangray
8230686a1b Import/Export - add definition setting to force a certain category
- update tracker to extend importexport_basic_import_csv
2019-03-07 15:52:48 -07:00