Add failing reproduction test case

* httpie/internal/daemons.py
* httpie/utils.py

CONTRIBUTING.md

@@ -59,8 +59,10 @@ $ git checkout -b my_topical_branch
 
 #### Setup
 
-The [Makefile](https://github.com/httpie/httpie/blob/master/Makefile) contains a bunch of tasks to get you started. Just run
+The [Makefile](https://github.com/httpie/httpie/blob/master/Makefile) contains a bunch of tasks to get you started.
-the following command, which:
+You can run `$ make` to see all the available tasks.
+
+To get started, run the command below, which:
 
 - Creates an isolated Python virtual environment inside `./venv`
   (via the standard library [venv](https://docs.python.org/3/library/venv.html) tool);
@@ -70,7 +72,7 @@ the following command, which:
 - and runs tests (It is the same as running `make install test`).
 
 ```bash
-$ make
+$ make all
 ```
 
 #### Python virtual environment

Makefile

@@ -22,6 +22,26 @@ VENV_PYTHON=$(VENV_BIN)/python
 export PATH := $(VENV_BIN):$(PATH)
 
 
+
+default: list-tasks
+
+
+###############################################################################
+# Default task to get a list of tasks when `make' is run without args.
+# <https://stackoverflow.com/questions/4219255>
+###############################################################################
+
+list-tasks:
+	@echo Available tasks:
+	@echo ----------------
+	@$(MAKE) -pRrq -f $(lastword $(MAKEFILE_LIST)) : 2>/dev/null | awk -v RS= -F: '/^# File/,/^# Finished Make data base/ {if ($$1 !~ "^[#.]") {print $$1}}' | sort | egrep -v -e '^[^[:alnum:]]' -e '^$@$$'
+	@echo
+
+
+###############################################################################
+# Installation
+###############################################################################
+
 all: uninstall-httpie install test
 
 
@@ -33,7 +53,7 @@ install-reqs:
 	$(VENV_PIP) install --upgrade pip wheel build
 
 	@echo $(H1)Installing dev requirements$(H1END)
-	$(VENV_PIP) install --upgrade --editable '.[dev]'
+	$(VENV_PIP) install --upgrade '.[dev]' '.[test]'
 
 	@echo $(H1)Installing HTTPie$(H1END)
 	$(VENV_PIP) install --upgrade --editable .

docs/README.md

@@ -2425,7 +2425,7 @@ You can check whether a new update is available for your system by running `http
 
 In the past `pip` was used to install/uninstall plugins, but on some environments (e.g., brew installed
 packages) it wasn’t working properly. The new interface is a very simple overlay on top of `pip` to allow
-plugin installations on every installation method.
+plugin installations on every installation method.
 
 By default, the plugins (and their missing dependencies) will be stored under the configuration directory,
 but this can be modified through `plugins_dir` variable on the config.

docs/installation/methods.yml

@@ -17,13 +17,13 @@ docs-structure:
   Windows:
     - chocolatey
   Linux:
-    - snap-linux
-    - brew-linux
     - apt
     - dnf
     - yum
-    - pacman
     - single-binary
+    - snap-linux
+    - brew-linux
+    - pacman
   FreeBSD:
     - pkg
 
@@ -191,6 +191,7 @@ tools:
     commands:
       install:
         - https --download packages.httpie.io/binaries/linux/http-latest -o http
-        - chmod +x ./http
+        - ln -ls ./http ./https
+        - chmod +x ./http ./https
       upgrade:
         - https --download packages.httpie.io/binaries/linux/http-latest -o http

extras/packaging/linux/build.py

@@ -6,6 +6,9 @@ from typing import Iterator, Tuple
 BUILD_DIR = Path(__file__).parent
 HTTPIE_DIR = BUILD_DIR.parent.parent.parent
 
+EXTRAS_DIR = HTTPIE_DIR / 'extras'
+MAN_PAGES_DIR = EXTRAS_DIR /  'man'
+
 SCRIPT_DIR = BUILD_DIR / Path('scripts')
 HOOKS_DIR = SCRIPT_DIR / 'hooks'
 
@@ -50,6 +53,11 @@ def build_packages(http_binary: Path, httpie_binary: Path) -> None:
         (http_binary, '/usr/bin/https'),
         (httpie_binary, '/usr/bin/httpie'),
     ]
+    files.extend(
+        (man_page, f'/usr/share/man/man1/{man_page.name}')
+        for man_page in MAN_PAGES_DIR.glob('*.1')
+    )
+
     # A list of additional dependencies
     deps = [
         'python3 >= 3.7',

httpie/cli/constants.py

@@ -132,10 +132,3 @@ class RequestType(enum.Enum):
     FORM = enum.auto()
     MULTIPART = enum.auto()
     JSON = enum.auto()
-
-
-EMPTY_STRING = ''
-OPEN_BRACKET = '['
-CLOSE_BRACKET = ']'
-BACKSLASH = '\\'
-HIGHLIGHTER = '^'

httpie/cli/nested_json.py

@@ -9,8 +9,14 @@ from typing import (
     Type,
     Union,
 )
-from httpie.cli.dicts import NestedJSONArray
+from .dicts import NestedJSONArray
-from httpie.cli.constants import EMPTY_STRING, OPEN_BRACKET, CLOSE_BRACKET, BACKSLASH, HIGHLIGHTER
+
+
+EMPTY_STRING = ''
+HIGHLIGHTER = '^'
+OPEN_BRACKET = '['
+CLOSE_BRACKET = ']'
+BACKSLASH = '\\'
 
 
 class HTTPieSyntaxError(ValueError):
@@ -31,7 +37,7 @@ class HTTPieSyntaxError(ValueError):
         if self.token is not None:
             lines.append(self.source)
             lines.append(
-                ' ' * (self.token.start)
+                ' ' * self.token.start
                 + HIGHLIGHTER * (self.token.end - self.token.start)
             )
         return '\n'.join(lines)
@@ -51,9 +57,15 @@ class TokenKind(Enum):
             return 'a ' + self.name.lower()
 
 
-OPERATORS = {OPEN_BRACKET: TokenKind.LEFT_BRACKET, CLOSE_BRACKET: TokenKind.RIGHT_BRACKET}
+OPERATORS = {
+    OPEN_BRACKET: TokenKind.LEFT_BRACKET,
+    CLOSE_BRACKET: TokenKind.RIGHT_BRACKET,
+}
 SPECIAL_CHARS = OPERATORS.keys() | {BACKSLASH}
-LITERAL_TOKENS = [TokenKind.TEXT, TokenKind.NUMBER]
+LITERAL_TOKENS = [
+    TokenKind.TEXT,
+    TokenKind.NUMBER,
+]
 
 
 class Token(NamedTuple):

httpie/client.py

@@ -13,7 +13,8 @@ import urllib3
 from . import __version__
 from .adapters import HTTPieHTTPAdapter
 from .context import Environment
-from .cli.constants import EMPTY_STRING, HTTP_OPTIONS
+from .cli.constants import HTTP_OPTIONS
+from .cli.nested_json import EMPTY_STRING
 from .cli.dicts import HTTPHeadersDict, NestedJSONArray
 from .encoding import UTF8
 from .models import RequestsMessage

httpie/internal/daemons.py

@@ -1,6 +1,6 @@
 """
 This module provides an interface to spawn a detached task to be
-runned with httpie.internal.daemon_runner on a separate process. It is
+run with httpie.internal.daemon_runner on a separate process. It is
 based on DVC's daemon system.
 https://github.com/iterative/dvc/blob/main/dvc/daemon.py
 """

httpie/utils.py

@@ -277,7 +277,7 @@ def open_with_lockfile(file: Path, *args, **kwargs) -> Generator[IO[Any], None,
     target_file = Path(tempfile.gettempdir()) / file_id
 
     # Have an atomic-like touch here, so we'll tighten the possibility of
-    # a race occuring between multiple processes accessing the same file.
+    # a race occurring between multiple processes accessing the same file.
     try:
         target_file.touch(exist_ok=False)
     except FileExistsError as exc:

tests/test_regressions.py

@@ -1,9 +1,12 @@
 """Miscellaneous regression tests"""
 import pytest
 
+from httpie.cli.argtypes import KeyValueArgType
+from httpie.cli.constants import SEPARATOR_HEADER, SEPARATOR_QUERY_PARAM, SEPARATOR_DATA_STRING
+from httpie.cli.requestitems import RequestItems
 from httpie.compat import is_windows
-from .utils.matching import assert_output_matches, Expect
 from .utils import HTTP_OK, MockEnvironment, http
+from .utils.matching import assert_output_matches, Expect
 
 
 def test_Host_header_overwrite(httpbin):
@@ -47,3 +50,21 @@ def test_verbose_redirected_stdout_separator(httpbin):
         Expect.RESPONSE_HEADERS,
         Expect.BODY,
     ])
+
+
+@pytest.mark.parametrize(['separator', 'target'], [
+    (SEPARATOR_HEADER, 'headers'),
+    (SEPARATOR_QUERY_PARAM, 'params'),
+    (SEPARATOR_DATA_STRING, 'data'),
+])
+def test_initial_backslash_number(separator, target):
+    """
+    <https://github.com/httpie/httpie/issues/1408>
+    """
+    back_digit = r'\0'
+    raw_arg = back_digit + separator + back_digit
+    expected_parsed_data = {back_digit: back_digit}
+    parsed_arg = KeyValueArgType(separator)(raw_arg)
+    items = RequestItems.from_args([parsed_arg])
+    parsed_data = getattr(items, target)
+    assert parsed_data == expected_parsed_data