nushell/crates/nu-command/tests/commands/network/http/get.rs

use mockito::Server;
use nu_test_support::{nu, pipeline};

#[test]
fn http_get_is_success() {
    let mut server = Server::new();

    let _mock = server.mock("GET", "/").with_body("foo").create();

    let actual = nu!(pipeline(
        format!(
            r#"
        http get {url}
        "#,
            url = server.url()
        )
        .as_str()
    ));

    assert_eq!(actual.out, "foo")
}

#[test]
fn http_get_failed_due_to_server_error() {
    let mut server = Server::new();

    let _mock = server.mock("GET", "/").with_status(400).create();

    let actual = nu!(pipeline(
        format!(
            r#"
        http get {url}
        "#,
            url = server.url()
        )
        .as_str()
    ));

    assert!(actual.err.contains("Bad request (400)"))
}

// These tests require network access; they use badssl.com which is a Google-affiliated site for testing various SSL errors.
// Revisit this if these tests prove to be flaky or unstable.

#[test]
fn http_get_expired_cert_fails() {
    let actual = nu!("http get https://expired.badssl.com/");
    assert!(actual.err.contains("network_failure"));
}

#[test]
fn http_get_expired_cert_override() {
    let actual = nu!("http get --insecure https://expired.badssl.com/");
    assert!(actual.out.contains("<html>"));
}

#[test]
fn http_get_self_signed_fails() {
    let actual = nu!("http get https://self-signed.badssl.com/");
    assert!(actual.err.contains("network_failure"));
}

#[test]
fn http_get_self_signed_override() {
    let actual = nu!("http get --insecure https://self-signed.badssl.com/");
    assert!(actual.out.contains("<html>"));
}
Add unit tests for HTTP commands. (#8267) # Description Following the comment from @fdncred: https://github.com/nushell/nushell/pull/8144#issuecomment-1442514338. I added some unit tests for HTTP commands. The tests are not exhaustive, but at least, this is a first good step IMO. # User-Facing Changes None. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. 2023-03-02 20:05:18 +01:00			`use mockito::Server;`
			`use nu_test_support::{nu, pipeline};`

			`#[test]`
			`fn http_get_is_success() {`
			`let mut server = Server::new();`

			`let _mock = server.mock("GET", "/").with_body("foo").create();`

			`let actual = nu!(pipeline(`
			`format!(`
			`r#"`
			`http get {url}`
			`"#,`
			`url = server.url()`
			`)`
			`.as_str()`
			`));`

			`assert_eq!(actual.out, "foo")`
			`}`

			`#[test]`
			`fn http_get_failed_due_to_server_error() {`
			`let mut server = Server::new();`

changes Reqwest to Ureq. (#8320) # Description _(Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes.)_ This pull request removes `Reqwest` and replaces it with `Ureq` to remove some of our dependencies, giving us faster compile times as well as smaller binaries. `Ureq` does not have an async runtime included so we do not need build heavy dependencies such as `Tokio`. From older tests I had the number of build units be reduced from `430 -> 392`. The default of `Ureq` uses `Rustls` but it has been configured to instead use `native_tls` which should work exactly the same as the `tls` works now. I removed `content-length` from the http commands as after refactoring i did not see a reason to have it available, correct me if this is something we should preserve. In the medium, to long term, we should maybe consider changing to `rustls` to have the same `tls` on all platforms. # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. 2023-03-05 23:48:13 +01:00			`let _mock = server.mock("GET", "/").with_status(400).create();`
Add unit tests for HTTP commands. (#8267) # Description Following the comment from @fdncred: https://github.com/nushell/nushell/pull/8144#issuecomment-1442514338. I added some unit tests for HTTP commands. The tests are not exhaustive, but at least, this is a first good step IMO. # User-Facing Changes None. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. 2023-03-02 20:05:18 +01:00
			`let actual = nu!(pipeline(`
			`format!(`
			`r#"`
			`http get {url}`
			`"#,`
			`url = server.url()`
			`)`
			`.as_str()`
			`));`

			`assert!(actual.err.contains("Bad request (400)"))`
			`}`
Add SSL tests for `http get` (#8327) This PR adds tests to confirm that: 1. `http get` does the right thing (bail) when it encounters common SSL errors 2. the `--insecure` flag works to ignore SSL errors It's prompted by #8098, where `--insecure` stopped working and we didn't notice until it was reported by a user. ## Deets + considerations This PR uses [badssl.com](https://badssl.com/), a very handy website affiliated with the Google Chrome team. The badssl authors mention that stability is not guaranteed: > Most subdomains are likely to have stable functionality, but anything could change without notice. I suspect that the badssl.com subdomains I've chosen will be stable enough in practice. Can revisit this if the tests end up being flaky. This PR does mean our tests are now making an external network call... which I _think_ is OK. Our CI isn't exactly designed for offline machines; test runners already have to download a bunch of crates etc. I think the new tests are quick enough: ![image](https://user-images.githubusercontent.com/26268125/222992751-a9f0d8ff-b776-4ea5-908a-7d11607487fe.png) 2023-03-07 16:56:39 +01:00
			`// These tests require network access; they use badssl.com which is a Google-affiliated site for testing various SSL errors.`
			`// Revisit this if these tests prove to be flaky or unstable.`

			`#[test]`
			`fn http_get_expired_cert_fails() {`
			`let actual = nu!("http get https://expired.badssl.com/");`
			`assert!(actual.err.contains("network_failure"));`
			`}`

			`#[test]`
			`fn http_get_expired_cert_override() {`
			`let actual = nu!("http get --insecure https://expired.badssl.com/");`
			`assert!(actual.out.contains("<html>"));`
			`}`

			`#[test]`
			`fn http_get_self_signed_fails() {`
			`let actual = nu!("http get https://self-signed.badssl.com/");`
			`assert!(actual.err.contains("network_failure"));`
			`}`

			`#[test]`
			`fn http_get_self_signed_override() {`
			`let actual = nu!("http get --insecure https://self-signed.badssl.com/");`
			`assert!(actual.out.contains("<html>"));`
			`}`