2021-12-07 21:06:34 +01:00
|
|
|
use nu_plugin::{EvaluatedCall, LabeledError};
|
|
|
|
use nu_protocol::Value;
|
|
|
|
pub struct Example;
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
fn print_values(
|
|
|
|
&self,
|
|
|
|
index: u32,
|
|
|
|
call: &EvaluatedCall,
|
|
|
|
input: &Value,
|
|
|
|
) -> Result<(), LabeledError> {
|
|
|
|
// Note. When debugging your plugin, you may want to print something to the console
|
|
|
|
// Use the eprintln macro to print your messages. Trying to print to stdout will
|
|
|
|
// cause a decoding error for your message
|
2023-01-30 02:37:54 +01:00
|
|
|
eprintln!("Calling test {index} signature");
|
|
|
|
eprintln!("value received {input:?}");
|
2021-12-07 21:06:34 +01:00
|
|
|
|
|
|
|
// To extract the arguments from the Call object you can use the functions req, has_flag,
|
|
|
|
// opt, rest, and get_flag
|
|
|
|
//
|
|
|
|
// Note that plugin calls only accept simple arguments, this means that you can
|
|
|
|
// pass to the plug in Int and String. This should be improved when the plugin has
|
|
|
|
// the ability to call back to NuShell to extract more information
|
|
|
|
// Keep this in mind when designing your plugin signatures
|
|
|
|
let a: i64 = call.req(0)?;
|
|
|
|
let b: String = call.req(1)?;
|
|
|
|
let flag = call.has_flag("flag");
|
|
|
|
let opt: Option<i64> = call.opt(2)?;
|
|
|
|
let named: Option<String> = call.get_flag("named")?;
|
|
|
|
let rest: Vec<String> = call.rest(3)?;
|
|
|
|
|
|
|
|
eprintln!("Required values");
|
2023-01-30 02:37:54 +01:00
|
|
|
eprintln!("a: {a:}");
|
|
|
|
eprintln!("b: {b:}");
|
|
|
|
eprintln!("flag: {flag:}");
|
|
|
|
eprintln!("rest: {rest:?}");
|
2021-12-07 21:06:34 +01:00
|
|
|
|
2023-01-24 12:23:42 +01:00
|
|
|
if let Some(v) = opt {
|
2023-01-30 02:37:54 +01:00
|
|
|
eprintln!("Found optional value opt: {v:}")
|
2023-01-24 12:23:42 +01:00
|
|
|
} else {
|
|
|
|
eprintln!("No optional value found")
|
2021-12-07 21:06:34 +01:00
|
|
|
}
|
|
|
|
|
2023-01-24 12:23:42 +01:00
|
|
|
if let Some(v) = named {
|
2023-01-30 02:37:54 +01:00
|
|
|
eprintln!("Named value: {v:?}")
|
2023-01-24 12:23:42 +01:00
|
|
|
} else {
|
|
|
|
eprintln!("No named value found")
|
2021-12-07 21:06:34 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
|
|
|
|
pub fn test1(&self, call: &EvaluatedCall, input: &Value) -> Result<Value, LabeledError> {
|
|
|
|
self.print_values(1, call, input)?;
|
|
|
|
|
|
|
|
Ok(Value::Nothing { span: call.head })
|
|
|
|
}
|
|
|
|
|
|
|
|
pub fn test2(&self, call: &EvaluatedCall, input: &Value) -> Result<Value, LabeledError> {
|
|
|
|
self.print_values(2, call, input)?;
|
|
|
|
|
|
|
|
let cols = vec!["one".to_string(), "two".to_string(), "three".to_string()];
|
|
|
|
|
|
|
|
let vals = (0..10i64)
|
|
|
|
.map(|i| {
|
|
|
|
let vals = (0..3)
|
Reduced LOC by replacing several instances of `Value::Int {}`, `Value::Float{}`, `Value::Bool {}`, and `Value::String {}` with `Value::int()`, `Value::float()`, `Value::boolean()` and `Value::string()` (#7412)
# Description
While perusing Value.rs, I noticed the `Value::int()`, `Value::float()`,
`Value::boolean()` and `Value::string()` constructors, which seem
designed to make it easier to construct various Values, but which aren't
used often at all in the codebase. So, using a few find-replaces
regexes, I increased their usage. This reduces overall LOC because
structures like this:
```
Value::Int {
val: a,
span: head
}
```
are changed into
```
Value::int(a, head)
```
and are respected as such by the project's formatter.
There are little readability concerns because the second argument to all
of these is `span`, and it's almost always extremely obvious which is
the span at every callsite.
# User-Facing Changes
None.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-09 17:37:51 +01:00
|
|
|
.map(|v| Value::int(v * i, call.head))
|
2021-12-07 21:06:34 +01:00
|
|
|
.collect::<Vec<Value>>();
|
|
|
|
|
|
|
|
Value::Record {
|
|
|
|
cols: cols.clone(),
|
|
|
|
vals,
|
|
|
|
span: call.head,
|
|
|
|
}
|
|
|
|
})
|
|
|
|
.collect::<Vec<Value>>();
|
|
|
|
|
|
|
|
Ok(Value::List {
|
|
|
|
vals,
|
|
|
|
span: call.head,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
pub fn test3(&self, call: &EvaluatedCall, input: &Value) -> Result<Value, LabeledError> {
|
|
|
|
self.print_values(3, call, input)?;
|
|
|
|
|
|
|
|
Err(LabeledError {
|
|
|
|
label: "ERROR from plugin".into(),
|
|
|
|
msg: "error message pointing to call head span".into(),
|
|
|
|
span: Some(call.head),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|