nushell/crates/nu-cmd-dataframe/src/lib.rs

#[cfg(feature = "dataframe")]
pub mod dataframe;
#[cfg(feature = "dataframe")]
pub use dataframe::*;
Put heavy dataframe dependencies behind feature flag (#9971) Context from Discord: https://discord.com/channels/601130461678272522/615962413203718156/1138694933545504819 I was working on Nu for the first time in a while and I noticed that sometimes rust-analyzer takes a really long time to run `cargo check` on the entire workspace. I dug in and it was checking a bunch of dataframe-related dependencies even though the `dataframe` feature is not built by default. It looks like this is a regression of sorts, introduced by https://github.com/nushell/nushell/pull/9241. Thankfully the fix is pretty easy, we can make it so everything important in `nu-cmd-dataframe` is only used when the `dataframe` feature is enabled. ### Impact on `cargo check --workspace` Before this PR: 635 crates, 33.59s After this PR: 498 crates, ~20s (with the `mold` linker and a `cargo clean` before each run, the relative difference for incremental checks will likely be much larger) 2023-08-10 07:36:09 +02:00			`#[cfg(feature = "dataframe")]`
move dataframe commands to nu-cmd-dataframe (#9241) All of the dataframe commands ported over with no issues... ### 11 tests are commented out (for now) So 100 of the original 111 tests are passing with only 11 tests being ignored for now.. As per our conversation in the core team meeting on Wednesday I took @jntrnr suggestion and just commented out the tests dealing with [IntoDatetime](https://github.com/nushell/nushell/blob/main/crates/nu-command/src/conversions/into/mod.rs) Later on we can move this functionality out of nu-command if we decide it makes sense... ### The following tests were ignored... ```rust modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_day.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_hour.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_minute.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_month.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_nanosecond.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_ordinal.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_second.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_week.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_weekday.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_year.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/string/strftime.rs ``` 2023-05-19 19:56:08 +02:00			`pub mod dataframe;`
Put heavy dataframe dependencies behind feature flag (#9971) Context from Discord: https://discord.com/channels/601130461678272522/615962413203718156/1138694933545504819 I was working on Nu for the first time in a while and I noticed that sometimes rust-analyzer takes a really long time to run `cargo check` on the entire workspace. I dug in and it was checking a bunch of dataframe-related dependencies even though the `dataframe` feature is not built by default. It looks like this is a regression of sorts, introduced by https://github.com/nushell/nushell/pull/9241. Thankfully the fix is pretty easy, we can make it so everything important in `nu-cmd-dataframe` is only used when the `dataframe` feature is enabled. ### Impact on `cargo check --workspace` Before this PR: 635 crates, 33.59s After this PR: 498 crates, ~20s (with the `mold` linker and a `cargo clean` before each run, the relative difference for incremental checks will likely be much larger) 2023-08-10 07:36:09 +02:00			`#[cfg(feature = "dataframe")]`
move dataframe commands to nu-cmd-dataframe (#9241) All of the dataframe commands ported over with no issues... ### 11 tests are commented out (for now) So 100 of the original 111 tests are passing with only 11 tests being ignored for now.. As per our conversation in the core team meeting on Wednesday I took @jntrnr suggestion and just commented out the tests dealing with [IntoDatetime](https://github.com/nushell/nushell/blob/main/crates/nu-command/src/conversions/into/mod.rs) Later on we can move this functionality out of nu-command if we decide it makes sense... ### The following tests were ignored... ```rust modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_day.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_hour.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_minute.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_month.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_nanosecond.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_ordinal.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_second.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_week.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_weekday.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/date/get_year.rs modified: crates/nu-cmd-dataframe/src/dataframe/series/string/strftime.rs ``` 2023-05-19 19:56:08 +02:00			`pub use dataframe::*;`