2022-02-04 03:01:45 +01:00
|
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn checks_all_rows_are_true() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(pipeline(
|
2022-02-04 03:01:45 +01:00
|
|
|
r#"
|
2022-02-21 14:38:15 +01:00
|
|
|
echo [ "Andrés", "Andrés", "Andrés" ]
|
2022-12-10 18:24:06 +01:00
|
|
|
| all {|it| $it == "Andrés" }
|
2022-02-04 03:01:45 +01:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "true");
|
2021-04-03 20:40:54 +02:00
|
|
|
}
|
|
|
|
|
2021-07-29 23:12:24 +02:00
|
|
|
#[test]
|
|
|
|
fn checks_all_rows_are_false_with_param() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#" [1, 2, 3, 4] | all { |a| $a >= 5 } "#);
|
2022-02-04 03:01:45 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "false");
|
2021-07-29 23:12:24 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn checks_all_rows_are_true_with_param() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#" [1, 2, 3, 4] | all { |a| $a < 5 } "#);
|
2022-02-04 03:01:45 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "true");
|
2021-07-29 23:12:24 +02:00
|
|
|
}
|
|
|
|
|
2021-04-03 20:40:54 +02:00
|
|
|
#[test]
|
|
|
|
fn checks_all_columns_of_a_table_is_true() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(pipeline(
|
2022-02-04 03:01:45 +01:00
|
|
|
r#"
|
2021-04-03 20:40:54 +02:00
|
|
|
echo [
|
|
|
|
[ first_name, last_name, rusty_at, likes ];
|
Require that values that look like numbers parse as numberlike (#8635)
# Description
Require that any value that looks like it might be a number (starts with
a digit, or a '-' + digit, or a '+' + digits, or a special form float
like `-inf`, `inf`, or `NaN`) must now be treated as a number-like
value. Number-like syntax can only parse into number-like values.
Number-like values include: durations, ints, floats, ranges, filesizes,
binary data, etc.
# User-Facing Changes
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
BREAKING CHANGE
Just making sure we see this for release notes 😅
This breaks any and all numberlike values that were treated as strings
before. Example, we used to allow `3,` as a bare word. Anything like
this would now require quotes or backticks to be treated as a string or
bare word, respectively.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-28 08:31:38 +02:00
|
|
|
[ Andrés, Robalino, '10/11/2013', 1 ]
|
|
|
|
[ JT, Turner, '10/12/2013', 1 ]
|
|
|
|
[ Darren, Schroeder, '10/11/2013', 1 ]
|
|
|
|
[ Yehuda, Katz, '10/11/2013', 1 ]
|
2021-04-03 20:40:54 +02:00
|
|
|
]
|
2022-12-10 18:24:06 +01:00
|
|
|
| all {|x| $x.likes > 0 }
|
2022-02-04 03:01:45 +01:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "true");
|
2021-04-03 20:40:54 +02:00
|
|
|
}
|
2022-07-24 13:28:12 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn checks_if_all_returns_error_with_invalid_command() {
|
2023-02-25 18:36:51 +01:00
|
|
|
// Using `with-env` to remove `st` possibly being an external program
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(pipeline(
|
2022-07-24 13:28:12 +02:00
|
|
|
r#"
|
2023-02-25 18:36:51 +01:00
|
|
|
with-env {PATH: ""} {
|
|
|
|
[red orange yellow green blue purple] | all {|it| ($it | st length) > 4 }
|
|
|
|
}
|
2022-07-24 13:28:12 +02:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
2022-08-07 20:40:41 +02:00
|
|
|
assert!(actual.err.contains("can't run executable") || actual.err.contains("did you mean"));
|
2022-07-24 13:28:12 +02:00
|
|
|
}
|
2022-11-01 19:36:54 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn works_with_1_param_blocks() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#"[1 2 3] | all {|e| print $e | true }"#);
|
2022-11-01 19:36:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "123true");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn works_with_0_param_blocks() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#"[1 2 3] | all {|| print $in | true }"#);
|
2022-11-01 19:36:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "123true");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn early_exits_with_1_param_blocks() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#"[1 2 3] | all {|e| print $e | false }"#);
|
2022-11-01 19:36:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "1false");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn early_exits_with_0_param_blocks() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#"[1 2 3] | all {|| print $in | false }"#);
|
2022-11-01 19:36:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "1false");
|
|
|
|
}
|
2022-11-09 23:05:15 +01:00
|
|
|
|
2022-11-21 14:35:11 +01:00
|
|
|
#[test]
|
2023-02-02 23:59:58 +01:00
|
|
|
fn all_uses_enumerate_index() {
|
2023-04-02 17:25:05 +02:00
|
|
|
let actual = nu!(r#"[7 8 9] | enumerate | all {|el| print $el.index | true }"#);
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "012true");
|
|
|
|
}
|
|
|
|
|
2022-11-09 23:05:15 +01:00
|
|
|
#[test]
|
|
|
|
fn unique_env_each_iteration() {
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats",
|
Restrict closure expression to be something like `{|| ...}` (#8290)
# Description
As title, closes: #7921 closes: #8273
# User-Facing Changes
when define a closure without pipe, nushell will raise error for now:
```
❯ let x = {ss ss}
Error: nu::parser::closure_missing_pipe
× Missing || inside closure
╭─[entry #2:1:1]
1 │ let x = {ss ss}
· ───┬───
· ╰── Parsing as a closure, but || is missing
╰────
help: Try add || to the beginning of closure
```
`any`, `each`, `all`, `where` command accepts closure, it forces user
input closure like `{||`, or parse error will returned.
```
❯ {major:2, minor:1, patch:4} | values | each { into string }
Error: nu::parser::closure_missing_pipe
× Missing || inside closure
╭─[entry #4:1:1]
1 │ {major:2, minor:1, patch:4} | values | each { into string }
· ───────┬───────
· ╰── Parsing as a closure, but || is missing
╰────
help: Try add || to the beginning of closure
```
`with-env`, `do`, `def`, `try` are special, they still remain the same,
although it says that it accepts a closure, but they don't need to be
written like `{||`, it's more likely a block but can capture variable
outside of scope:
```
❯ def test [input] { echo [0 1 2] | do { do { echo $input } } }; test aaa
aaa
```
Just realize that It's a big breaking change, we need to update config
and scripts...
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-17 13:36:28 +01:00
|
|
|
"[1 2] | all {|| print ($env.PWD | str ends-with 'formats') | cd '/' | true } | to nuon"
|
2022-11-09 23:05:15 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "truetruetrue");
|
|
|
|
}
|