forked from extern/nushell
Change PluginCommand API to be more like Command (#12279)
# Description
This is something that was discussed in the core team meeting last
Wednesday. @ayax79 is building `nu-plugin-polars` with all of the
dataframe commands into a plugin, and there are a lot of them, so it
would help to make the API more similar. At the same time, I think the
`Command` API is just better anyway. I don't think the difference is
justified, and the types for core commands have the benefit of requiring
less `.into()` because they often don't own their data
- Broke `signature()` up into `name()`, `usage()`, `extra_usage()`,
`search_terms()`, `examples()`
- `signature()` returns `nu_protocol::Signature`
- `examples()` returns `Vec<nu_protocol::Example>`
- `PluginSignature` and `PluginExample` no longer need to be used by
plugin developers
# User-Facing Changes
Breaking API for plugins yet again 😄
This commit is contained in:
@ -1,6 +1,6 @@
|
||||
use crate::{inc::SemVerAction, Inc};
|
||||
use nu_plugin::{EngineInterface, EvaluatedCall, Plugin, PluginCommand, SimplePluginCommand};
|
||||
use nu_protocol::{ast::CellPath, LabeledError, PluginSignature, SyntaxShape, Value};
|
||||
use nu_protocol::{ast::CellPath, LabeledError, Signature, SyntaxShape, Value};
|
||||
|
||||
pub struct IncPlugin;
|
||||
|
||||
@ -13,9 +13,16 @@ impl Plugin for IncPlugin {
|
||||
impl SimplePluginCommand for Inc {
|
||||
type Plugin = IncPlugin;
|
||||
|
||||
fn signature(&self) -> PluginSignature {
|
||||
PluginSignature::build("inc")
|
||||
.usage("Increment a value or version. Optionally use the column of a table.")
|
||||
fn name(&self) -> &str {
|
||||
"inc"
|
||||
}
|
||||
|
||||
fn usage(&self) -> &str {
|
||||
"Increment a value or version. Optionally use the column of a table."
|
||||
}
|
||||
|
||||
fn signature(&self) -> Signature {
|
||||
Signature::build(PluginCommand::name(self))
|
||||
.optional("cell_path", SyntaxShape::CellPath, "cell path to update")
|
||||
.switch(
|
||||
"major",
|
||||
|
Reference in New Issue
Block a user