holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

allow collect warning

Browse Source
This commit is contained in:
Fernando Herrera 2021-09-23 20:39:42 +01:00
parent 772f8598dd
commit 04990eeba4
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
crates/nu-command/src/lines.rs
View File

@ -29,17 +29,22 @@ impl Command for Lines {
input: Value,
) -> Result<nu_protocol::Value, nu_protocol::ShellError> {
let value = match input {
#[allow(clippy::needless_collect)]
// Collect is needed because the string may not live long enough for
// the Rc structure to continue using it. If split could take ownership
// of the split values, then this wouldn't be needed
Value::String { val, span } => {
let iter = val
let lines = val
.split(SPLIT_CHAR)
.map(|s| Value::String {
val: s.into(),
span,
})
.collect::<Vec<Value>>(); // <----- how to avoid collecting?
.map(|s| s.to_string())
.collect::<Vec<String>>();
let iter = lines
.into_iter()
.map(move |s| Value::String { val: s, span });
Value::Stream {
stream: ValueStream(Rc::new(RefCell::new(iter.into_iter()))),
stream: ValueStream(Rc::new(RefCell::new(iter))),
span: Span::unknown(),
}
}
@ -67,11 +72,10 @@ impl Command for Lines {
None
}
})
.flatten()
.collect::<Vec<Value>>(); // <----- how to avoid collecting?
.flatten();
Value::Stream {
stream: ValueStream(Rc::new(RefCell::new(iter.into_iter()))),
stream: ValueStream(Rc::new(RefCell::new(iter))),
span: Span::unknown(),
}
}