holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not create help for wrapped command (#11235)

Browse Source 
Pretty self-explanatory.  The commit is only one `if`.

Fix #11096
This commit is contained in:
Andrej Kolchin 2023-12-05 19:04:36 +00:00 committed by GitHub
parent fb3350ebc3
commit 05d7d6d6ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/nu-command/tests/commands/def.rs
View File

@ -299,3 +299,9 @@ fn def_env_wrapped() {
); );
assert_eq!(actual.out, "bacon"); assert_eq!(actual.out, "bacon");
} }
#[test]
fn def_env_wrapped_no_help() {
let actual = nu!("def --wrapped foo [...rest] { echo $rest }; foo -h | to json --raw");
assert_eq!(actual.out, r#"["-h"]"#);
}

4
crates/nu-parser/src/parse_keywords.rs
View File

@ -580,7 +580,9 @@ pub fn parse_def(
let declaration = working_set.get_decl_mut(decl_id); let declaration = working_set.get_decl_mut(decl_id);
signature.name = name.clone(); signature.name = name.clone();
*signature = signature.add_help(); if !has_wrapped {
*signature = signature.add_help();
}
signature.usage = usage; signature.usage = usage;
signature.extra_usage = extra_usage; signature.extra_usage = extra_usage;
signature.allows_unknown_args = has_wrapped; signature.allows_unknown_args = has_wrapped;