From 083dcd45414e4c3dfcb8e83cc004e9e09b83f026 Mon Sep 17 00:00:00 2001
From: JT <jonathan.d.turner@gmail.com>
Date: Fri, 30 Jul 2021 19:50:39 +1200
Subject: [PATCH] Better for loop

---
 src/eval.rs | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/src/eval.rs b/src/eval.rs
index 79b6011df..7ce02c33f 100644
--- a/src/eval.rs
+++ b/src/eval.rs
@@ -235,31 +235,20 @@ fn eval_call(state: &State, stack: Stack, call: &Call) -> Result<Value, ShellErr
 
         let stack = StackFrame::enter_scope(stack);
 
-        StackFrame::add_var(
-            stack.clone(),
-            var_id,
-            Value::Int {
-                val: 0,
-                span: Span::unknown(),
-            },
-        );
+        let mut x = Value::Int {
+            val: 0,
+            span: Span::unknown(),
+        };
 
         loop {
-            let curr = StackFrame::get_var(stack.clone(), var_id)?;
-
-            if curr == end_val {
+            if x == end_val {
                 break;
             } else {
+                StackFrame::add_var(stack.clone(), var_id, x.clone());
                 eval_block(state, stack.clone(), block)?;
-
-                StackFrame::add_var(
-                    stack.clone(),
-                    var_id,
-                    curr.add(&Value::Int {
-                        val: 1,
-                        span: Span::unknown(),
-                    })?,
-                );
+            }
+            if let Value::Int { ref mut val, .. } = x {
+                *val += 1
             }
         }
         Ok(Value::Unknown)