holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

📝 Update str trim CLI help doc (#11383)

Browse Source 
# Description
Hi! I updated the samples of `str trim` because there were repeated and
clarified the explanations

# User-Facing Changes
Yes! I send the details here:


![image](https://github.com/nushell/nushell/assets/30557287/e30a5612-4214-4365-8b83-7aefbc0ee825)

(`old` is version `88.1` not the latest main)

# Tests + Formatting
~~I ran `toolkit check pr` successfully~~

There was a tiny problem, a test I never touched now it's failing

```nu
(^echo a | complete) == {stdout: "a\n", exit_code: 0}
```
should output `true` but outputs `false`, both in my running `nu`
version and in my PR version
This make the test `nu-command::main commands::complete::basic` fail
located in `crates\nu-command\tests\commands\complete.rs`

# After Submitting
I'm not sure if I need to update nushell.github.io, some of the help is
auto-generated, but maybe not all?
I can file a PR if needed
This commit is contained in:
Auca Coyan 2023-12-20 17:23:41 -03:00 committed by GitHub
parent ff6a67d293
commit 109f629cb6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crates/nu-command/src/strings/str_/trim/trim_.rs
View File

@ -133,27 +133,22 @@ impl Command for SubCommand {
result: Some(Value::test_string("Nu shell")), result: Some(Value::test_string("Nu shell")),
}, },
Example { Example {
description: "Trim a specific character", description: "Trim a specific character (not the whitespace)",
example: "'=== Nu shell ===' | str trim --char '=' | str trim", example: "'=== Nu shell ===' | str trim --char '='",
result: Some(Value::test_string("Nu shell")), result: Some(Value::test_string(" Nu shell ")),
}, },
Example { Example {
description: "Trim whitespace from the beginning of string", description: "Trim whitespace from the beginning of string",
example: "' Nu shell ' | str trim --left", example: "' Nu shell ' | str trim --left",
result: Some(Value::test_string("Nu shell ")), result: Some(Value::test_string("Nu shell ")),
}, },
Example {
description: "Trim a specific character",
example: "'=== Nu shell ===' | str trim --char '='",
result: Some(Value::test_string(" Nu shell ")),
},
Example { Example {
description: "Trim whitespace from the end of string", description: "Trim whitespace from the end of string",
example: "' Nu shell ' | str trim --right", example: "' Nu shell ' | str trim --right",
result: Some(Value::test_string(" Nu shell")), result: Some(Value::test_string(" Nu shell")),
}, },
Example { Example {
description: "Trim a specific character", description: "Trim a specific character only from the end of the string",
example: "'=== Nu shell ===' | str trim --right --char '='", example: "'=== Nu shell ===' | str trim --right --char '='",
result: Some(Value::test_string("=== Nu shell ")), result: Some(Value::test_string("=== Nu shell ")),
}, },