forked from extern/nushell
Disable pipeline echo (#8292)
# Description Change behavior of block evaluation to not print result of intermediate commands. Previously result of every but last pipeline in a block was printed to stdout, and last one was returned  With this change results of intermediate pipelines are discarded after they finish and the last one is returned as before:  Now one should use `print` explicitly to print something to stdout  **Note, that this behavior is not limited to functions!** The scope of this change are all blocks. All of the below are executed as blocks and thus exibited this behavior in the same way:  With this change outputs for all types of blocks are cleaned:  # User-Facing Changes All types of blocks (function bodies, closures, `if` branches, `for` and `loop` bodies e.t.c.) no longer print result of intermediate pipelines. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -21,7 +21,7 @@ fn for_break_on_external_failed() {
|
||||
cwd: ".",
|
||||
r#"
|
||||
for i in 1..2 {
|
||||
echo 1;
|
||||
print 1;
|
||||
nu --testbin fail
|
||||
}"#
|
||||
);
|
||||
|
@ -33,7 +33,7 @@ fn loop_break_on_external_failed() {
|
||||
} else {
|
||||
$total += 1;
|
||||
}
|
||||
echo 1;
|
||||
print 1;
|
||||
nu --testbin fail;
|
||||
}"#
|
||||
);
|
||||
|
@ -262,10 +262,10 @@ fn test_open_block_command() {
|
||||
r#"
|
||||
def "from blockcommandparser" [] { lines | split column ",|," }
|
||||
let values = (open sample.blockcommandparser)
|
||||
echo ($values | get column1 | get 0)
|
||||
echo ($values | get column2 | get 0)
|
||||
echo ($values | get column1 | get 1)
|
||||
echo ($values | get column2 | get 1)
|
||||
print ($values | get column1 | get 0)
|
||||
print ($values | get column2 | get 0)
|
||||
print ($values | get column1 | get 1)
|
||||
print ($values | get column2 | get 1)
|
||||
"#
|
||||
);
|
||||
|
||||
|
@ -54,7 +54,7 @@ fn external_failed_should_be_caught() {
|
||||
fn loop_try_break_should_be_successful() {
|
||||
let output = nu!(
|
||||
cwd: ".",
|
||||
"loop { try { echo 'successful'; break } catch { echo 'failed'; continue } }"
|
||||
"loop { try { print 'successful'; break } catch { print 'failed'; continue } }"
|
||||
);
|
||||
|
||||
assert_eq!(output.out, "successful");
|
||||
@ -66,7 +66,7 @@ fn loop_catch_break_should_show_failed() {
|
||||
cwd: ".",
|
||||
"loop {
|
||||
try { invalid 1;
|
||||
continue; } catch { echo 'failed'; break }
|
||||
continue; } catch { print 'failed'; break }
|
||||
}
|
||||
"
|
||||
);
|
||||
|
@ -26,7 +26,7 @@ fn while_auto_print_in_each_iteration() {
|
||||
fn while_break_on_external_failed() {
|
||||
let actual = nu!(
|
||||
cwd: ".",
|
||||
"mut total = 0; while $total < 2 { $total = $total + 1; echo 1; nu --testbin fail }"
|
||||
"mut total = 0; while $total < 2 { $total = $total + 1; print 1; nu --testbin fail }"
|
||||
);
|
||||
// Note: nu! macro auto replace "\n" and "\r\n" with ""
|
||||
// so our output will be `1`
|
||||
|
@ -71,11 +71,11 @@ fn with_env_hides_variables_in_parent_scope() {
|
||||
cwd: "tests/fixtures/formats",
|
||||
r#"
|
||||
let-env FOO = "1"
|
||||
echo $env.FOO
|
||||
print $env.FOO
|
||||
with-env [FOO null] {
|
||||
echo $env.FOO
|
||||
}
|
||||
echo $env.FOO
|
||||
print $env.FOO
|
||||
"#
|
||||
);
|
||||
|
||||
@ -88,9 +88,9 @@ fn with_env_shorthand_can_not_hide_variables() {
|
||||
cwd: "tests/fixtures/formats",
|
||||
r#"
|
||||
let-env FOO = "1"
|
||||
echo $env.FOO
|
||||
FOO=null echo $env.FOO
|
||||
echo $env.FOO
|
||||
print $env.FOO
|
||||
FOO=null print $env.FOO
|
||||
print $env.FOO
|
||||
"#
|
||||
);
|
||||
|
||||
|
Reference in New Issue
Block a user