holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Slim down tests (#9021)

Browse Source 
This PR just tidies up some tests by removing unused code:

1. If the filesystem is not touched, don't use the filesystem
playground/sandbox
2. If the filesystem is not touched, don't specify the `cwd`
3. If the command is short, don't bother wrapping it in `pipeline()`
4. If the command doesn't have quotes, don't bother with a `r#"..."#`
raw string

Part of #8670.
This commit is contained in:
Reilly Wood
2023-04-28 04:25:44 -07:00
committed by GitHub
parent 4c4c1f6147
commit 3076378373
13 changed files with 80 additions and 345 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
crates/nu-command/tests/commands/reject.rs
View File

@ -2,7 +2,7 @@ use nu_test_support::{nu, pipeline};
#[test]
fn regular_columns() {
let actual = nu!(cwd: ".", pipeline(
let actual = nu!(pipeline(
r#"
echo [
[first_name, last_name, rusty_at, type];
@ -22,15 +22,14 @@ fn regular_columns() {
#[test]
fn skip_cell_rejection() {
let actual = nu!(cwd: ".", pipeline(
r#"[ {a: 1, b: 2,c:txt}, { a:val } ] | reject a | get c?.0"#));
let actual = nu!("[ {a: 1, b: 2,c:txt}, { a:val } ] | reject a | get c?.0");
assert_eq!(actual.out, "txt");
}
#[test]
fn complex_nested_columns() {
let actual = nu!(cwd: ".", pipeline(
let actual = nu!(pipeline(
r#"
{
"nu": {
@ -63,7 +62,7 @@ fn complex_nested_columns() {
#[test]
fn ignores_duplicate_columns_rejected() {
let actual = nu!(cwd: ".", pipeline(
let actual = nu!(pipeline(
r#"
echo [
["first name", "last name"];
@ -82,60 +81,36 @@ fn ignores_duplicate_columns_rejected() {
#[test]
fn reject_record_from_raw_eval() {
let actual = nu!(
cwd: ".", pipeline(
r#"
{"a": 3} | reject a | describe
"#
)
);
let actual = nu!(r#"{"a": 3} | reject a | describe"#);
assert!(actual.out.contains("record"));
}
#[test]
fn reject_table_from_raw_eval() {
let actual = nu!(
cwd: ".", pipeline(
r#"
[{"a": 3}] | reject a
"#
)
);
let actual = nu!(r#"[{"a": 3}] | reject a"#);
assert!(actual.out.contains("record 0 fields"));
}
#[test]
fn reject_nested_field() {
let actual = nu!(
cwd: ".", pipeline(
r#"
{a:{b:3,c:5}} | reject a.b | debug
"#
)
);
let actual = nu!("{a:{b:3,c:5}} | reject a.b | debug");
assert_eq!(actual.out, "{a: {c: 5}}");
}
#[test]
fn reject_two_identical_elements() {
let actual = nu!(
cwd: ".", pipeline(
r#"[[a, a]; [1, 2]] | reject a"#
)
);
let actual = nu!("[[a, a]; [1, 2]] | reject a");
assert!(actual.out.contains("record 0 fields"));
}
#[test]
fn reject_large_vec_with_two_identical_elements() {
let actual = nu!(
cwd: ".", pipeline(
r#"[[a, b, c, d, e, a]; [1323, 23, 45, 100, 2, 2423]] | reject a"#
)
);
let actual = nu!("[[a, b, c, d, e, a]; [1323, 23, 45, 100, 2, 2423]] | reject a");
assert!(!actual.out.contains("1323"));
assert!(!actual.out.contains("2423"));
assert!(actual.out.contains('b'));