holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Slim down tests (#9021)

Browse Source 
This PR just tidies up some tests by removing unused code:

1. If the filesystem is not touched, don't use the filesystem
playground/sandbox
2. If the filesystem is not touched, don't specify the `cwd`
3. If the command is short, don't bother wrapping it in `pipeline()`
4. If the command doesn't have quotes, don't bother with a `r#"..."#`
raw string

Part of #8670.
This commit is contained in:
Reilly Wood
2023-04-28 04:25:44 -07:00
committed by GitHub
parent 4c4c1f6147
commit 3076378373
13 changed files with 80 additions and 345 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
crates/nu-command/tests/commands/sort.rs
View File

@ -35,12 +35,7 @@ fn sort_primitive_values() {
#[test]
fn sort_different_types() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
r#"
[a, 1, b, 2, c, 3, [4, 5, 6], d, 4, [1, 2, 3]] | sort | to json --raw
"#
));
let actual = nu!("[a, 1, b, 2, c, 3, [4, 5, 6], d, 4, [1, 2, 3]] | sort | to json --raw");
let json_output = r#"[1,2,3,4,"a","b","c","d",[1,2,3],[4,5,6]]"#;
assert_eq!(actual.out, json_output);
@ -48,20 +43,14 @@ fn sort_different_types() {
#[test]
fn sort_natural() {
let actual = nu!(
cwd: ".", pipeline(
r#"['1' '2' '3' '4' '5' '10' '100'] | sort -n | to nuon"#
));
let actual = nu!("['1' '2' '3' '4' '5' '10' '100'] | sort -n | to nuon");
assert_eq!(actual.out, r#"["1", "2", "3", "4", "5", "10", "100"]"#);
}
#[test]
fn sort_record_natural() {
let actual = nu!(
cwd: ".", pipeline(
r#"{10:0,99:0,1:0,9:0,100:0} | sort -n | to nuon"#
));
let actual = nu!("{10:0,99:0,1:0,9:0,100:0} | sort -n | to nuon");
assert_eq!(
actual.out,
@ -71,50 +60,35 @@ fn sort_record_natural() {
#[test]
fn sort_record_insensitive() {
let actual = nu!(
cwd: ".", pipeline(
r#"{abe:1,zed:2,ABE:3} | sort -i | to nuon"#
));
let actual = nu!("{abe:1,zed:2,ABE:3} | sort -i | to nuon");
assert_eq!(actual.out, r#"{abe: 1, ABE: 3, zed: 2}"#);
}
#[test]
fn sort_record_insensitive_reverse() {
let actual = nu!(
cwd: ".", pipeline(
r#"{abe:1,zed:2,ABE:3} | sort -ir | to nuon"#
));
let actual = nu!("{abe:1,zed:2,ABE:3} | sort -ir | to nuon");
assert_eq!(actual.out, r#"{zed: 2, ABE: 3, abe: 1}"#);
}
#[test]
fn sort_record_values_natural() {
let actual = nu!(
cwd: ".", pipeline(
r#"{1:"1",2:"2",4:"100",3:"10"} | sort -vn | to nuon"#
));
let actual = nu!(r#"{1:"1",2:"2",4:"100",3:"10"} | sort -vn | to nuon"#);
assert_eq!(actual.out, r#"{"1": "1", "2": "2", "3": "10", "4": "100"}"#);
}
#[test]
fn sort_record_values_insensitive() {
let actual = nu!(
cwd: ".", pipeline(
r#"{1:abe,2:zed,3:ABE} | sort -vi | to nuon"#
));
let actual = nu!("{1:abe,2:zed,3:ABE} | sort -vi | to nuon");
assert_eq!(actual.out, r#"{"1": abe, "3": ABE, "2": zed}"#);
}
#[test]
fn sort_record_values_insensitive_reverse() {
let actual = nu!(
cwd: ".", pipeline(
r#"{1:abe,2:zed,3:ABE} | sort -vir | to nuon"#
));
let actual = nu!("{1:abe,2:zed,3:ABE} | sort -vir | to nuon");
assert_eq!(actual.out, r#"{"2": zed, "3": ABE, "1": abe}"#);
}