Remove the old it-hacks from fetch and post (#1807)

crates/nu_plugin_post/src/nu/mod.rs

@@ -1,7 +1,7 @@
 use futures::executor::block_on;
 use nu_errors::ShellError;
 use nu_plugin::Plugin;
-use nu_protocol::{CallInfo, ReturnValue, Signature, SyntaxShape, Value};
+use nu_protocol::{CallInfo, ReturnValue, Signature, SyntaxShape};
 
 use crate::post::post_helper;
 use crate::Post;
@@ -46,10 +46,6 @@ impl Plugin for Post {
 
     fn begin_filter(&mut self, call_info: CallInfo) -> Result<Vec<ReturnValue>, ShellError> {
         self.setup(call_info)?;
-        Ok(vec![])
-    }
-
-    fn filter(&mut self, row: Value) -> Result<Vec<ReturnValue>, ShellError> {
         Ok(vec![block_on(post_helper(
             &self.path.clone().ok_or_else(|| {
                 ShellError::labeled_error("expected a 'path'", "expected a 'path'", &self.tag)
@@ -61,7 +57,6 @@ impl Plugin for Post {
             self.user.clone(),
             self.password.clone(),
             &self.headers.clone(),
-            row,
         ))])
     }
 }

crates/nu_plugin_post/src/post.rs

@@ -87,29 +87,9 @@ pub async fn post_helper(
     user: Option<String>,
     password: Option<String>,
     headers: &[HeaderKind],
-    row: Value,
 ) -> ReturnValue {
     let path_tag = path.tag.clone();
-    let path_str = path.as_string()?.to_string();
-
-    //FIXME: this is a workaround because plugins don't yet support per-item iteration
-    let path_str = if path_str == "$it" {
-        let path_buf = row.as_path()?;
-        path_buf.display().to_string()
-    } else {
-        path_str
-    };
-
-    //FIXME: this is a workaround because plugins don't yet support per-item iteration
-    let body = if let Ok(x) = body.as_string() {
-        if x == "$it" {
-            &row
-        } else {
-            body
-        }
-    } else {
-        body
-    };
+    let path_str = path.as_string()?;
 
     let (file_extension, contents, contents_tag) =
         post(&path_str, &body, user, password, &headers, path_tag.clone()).await?;