holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove use of deprecated actions-rs/cargo GH action (#7375)

Browse Source 
Our CI actions have a lot of warnings like this:

>  nu-fmt-clippy (ubuntu-20.04, stable)
> Node.js 12 actions are deprecated. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16:
actions-rs/cargo@v1.0.1

[It looks like `actions-rs/cargo` is
abandoned](https://github.com/actions-rs/toolchain/issues/216). But the
good news is we don't actually need it, we can just run `cargo`
subcommands without a special action because we've already installed
`cargo` with `actions-rust-lang/setup-rust-toolchain`.
This commit is contained in:
Reilly Wood 2022-12-06 18:57:07 -08:00 committed by GitHub
parent 3395beaa56
commit 5114dfca7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
.github/workflows/ci.yml vendored
View File

@ -28,17 +28,11 @@ jobs:
- name: Setup Rust toolchain and cache - name: Setup Rust toolchain and cache
uses: actions-rust-lang/setup-rust-toolchain@v1.3.4 uses: actions-rust-lang/setup-rust-toolchain@v1.3.4
- name: Rustfmt - name: cargo fmt
uses: actions-rs/cargo@v1.0.1 run: cargo fmt --all -- --check
with:
command: fmt
args: --all -- --check
- name: Clippy - name: Clippy
uses: actions-rs/cargo@v1.0.1 run: cargo clippy --workspace --exclude nu_plugin_* -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
with:
command: clippy
args: --workspace --exclude nu_plugin_* -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
nu-tests: nu-tests:
env: env:
@ -72,10 +66,7 @@ jobs:
uses: actions-rust-lang/setup-rust-toolchain@v1.3.4 uses: actions-rust-lang/setup-rust-toolchain@v1.3.4
- name: Tests - name: Tests
uses: actions-rs/cargo@v1.0.1 run: cargo test --workspace --profile ci --exclude nu_plugin_* ${{ matrix.flags }}
with:
command: test
args: --workspace --profile ci --exclude nu_plugin_* ${{ matrix.flags }}
python-virtualenv: python-virtualenv:
env: env:
@ -99,10 +90,7 @@ jobs:
uses: actions-rust-lang/setup-rust-toolchain@v1.3.4 uses: actions-rust-lang/setup-rust-toolchain@v1.3.4
- name: Install Nushell - name: Install Nushell
uses: actions-rs/cargo@v1.0.1 run: cargo install --locked --path=. --profile ci --no-default-features
with:
command: install
args: --locked --path=. --profile ci --no-default-features
- name: Setup Python - name: Setup Python
uses: actions/setup-python@v4 uses: actions/setup-python@v4
@ -141,13 +129,7 @@ jobs:
uses: actions-rust-lang/setup-rust-toolchain@v1.3.4 uses: actions-rust-lang/setup-rust-toolchain@v1.3.4
- name: Clippy - name: Clippy
uses: actions-rs/cargo@v1.0.1 run: cargo clippy --package nu_plugin_* ${{ matrix.flags }} -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
with:
command: clippy
args: --package nu_plugin_* ${{ matrix.flags }} -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
- name: Tests - name: Tests
uses: actions-rs/cargo@v1.0.1 run: cargo test --profile ci --package nu_plugin_*
with:
command: test
args: --profile ci --package nu_plugin_*