holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove file I/O from tests that don't need it (#11182)

Browse Source 
# Description

This PR implements modifications to command tests that write unnecessary
json and csv to disk then load it with open, by using nuon literals
instead.

- Fixes #7189



# User-Facing Changes
None

# Tests + Formatting
This only affects existing tests, which still pass.
This commit is contained in:
Renan Ribeiro
2023-11-29 19:21:34 -03:00
committed by GitHub
parent d08e254d16
commit 54d73748e4
20 changed files with 414 additions and 760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
crates/nu-command/tests/commands/histogram.rs
View File

@ -1,95 +1,61 @@
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
use nu_test_support::playground::Playground;
use nu_test_support::{nu, pipeline};
const SAMPLE_INPUT: &str = r#"
[[first_name, last_name, rusty_at];
[Andrés, Robalino, Ecuador],
[JT, Turner, "Estados Unidos"],
[Yehuda, Katz, "Estados Unidos"]]
"#;
#[test]
fn summarizes_by_column_given() {
Playground::setup("histogram_test_1", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_tres_caballeros.csv",
r#"
first_name,last_name,rusty_at
Andrés,Robalino,Ecuador
JT,Turner,Estados Unidos
Yehuda,Katz,Estados Unidos
"#,
)]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open los_tres_caballeros.csv
let actual = nu!(pipeline(&format!(
r#"
{SAMPLE_INPUT}
| histogram rusty_at countries --percentage-type relative
| where rusty_at == "Ecuador"
| get countries
| get 0
"#
));
)));
assert_eq!(
actual.out,
"**************************************************"
);
// 50%
})
assert_eq!(
actual.out,
"**************************************************"
);
// 50%
}
#[test]
fn summarizes_by_column_given_with_normalize_percentage() {
Playground::setup("histogram_test_1", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_tres_caballeros.csv",
r#"
first_name,last_name,rusty_at
Andrés,Robalino,Ecuador
JT,Turner,Estados Unidos
Yehuda,Katz,Estados Unidos
"#,
)]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open los_tres_caballeros.csv
let actual = nu!(pipeline(&format!(
r#"
{SAMPLE_INPUT}
| histogram rusty_at countries
| where rusty_at == "Ecuador"
| get countries
| get 0
"#
));
)));
assert_eq!(actual.out, "*********************************");
// 33%
})
assert_eq!(actual.out, "*********************************");
// 33%
}
#[test]
fn summarizes_by_values() {
Playground::setup("histogram_test_2", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_tres_caballeros.csv",
r#"
first_name,last_name,rusty_at
Andrés,Robalino,Ecuador
JT,Turner,Estados Unidos
Yehuda,Katz,Estados Unidos
"#,
)]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open los_tres_caballeros.csv
let actual = nu!(pipeline(&format!(
r#"
{SAMPLE_INPUT}
| get rusty_at
| histogram
| where value == "Estados Unidos"
| get count
| get 0
"#
));
)));
assert_eq!(actual.out, "2");
})
assert_eq!(actual.out, "2");
}
#[test]