holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove file I/O from tests that don't need it (#11182)

Browse Source 
# Description

This PR implements modifications to command tests that write unnecessary
json and csv to disk then load it with open, by using nuon literals
instead.

- Fixes #7189



# User-Facing Changes
None

# Tests + Formatting
This only affects existing tests, which still pass.
This commit is contained in:
Renan Ribeiro
2023-11-29 19:21:34 -03:00
committed by GitHub
parent d08e254d16
commit 54d73748e4
20 changed files with 414 additions and 760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
crates/nu-command/tests/commands/move_/column.rs
View File

@ -1,130 +1,102 @@
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
use nu_test_support::playground::Playground;
use nu_test_support::{nu, pipeline};
#[test]
fn moves_a_column_before() {
Playground::setup("move_column_test_1", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"sample.csv",
r#"
column1,column2,column3,...,column98,column99,column100
-------,-------,-------,---,--------, A ,---------
-------,-------,-------,---,--------, N ,---------
-------,-------,-------,---,--------, D ,---------
-------,-------,-------,---,--------, R ,---------
-------,-------,-------,---,--------, E ,---------
-------,-------,-------,---,--------, S ,---------
"#,
)]);
let sample = r#"
[[column1 column2 column3 ... column98 column99 column100];
[------- ------- ------- --- -------- " A " ---------],
[------- ------- ------- --- -------- " N " ---------],
[------- ------- ------- --- -------- " D " ---------],
[------- ------- ------- --- -------- " R " ---------],
[------- ------- ------- --- -------- " E " ---------],
[------- ------- ------- --- -------- " S " ---------]]"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open sample.csv
let actual = nu!(pipeline(&format!(
r#"
{sample}
| move column99 --before column1
| rename chars
| get chars
| str trim
| str join
"#
));
)));
assert!(actual.out.contains("ANDRES"));
})
assert!(actual.out.contains("ANDRES"));
}
#[test]
fn moves_columns_before() {
Playground::setup("move_column_test_2", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"sample.csv",
r#"
column1,column2,column3,...,column98,column99,column100
-------,-------, A ,---,--------, N ,---------
-------,-------, D ,---,--------, R ,---------
-------,-------, E ,---,--------, S ,---------
-------,-------, : ,---,--------, : ,---------
-------,-------, J ,---,--------, T ,---------
"#,
)]);
let sample = r#"
[[column1 column2 column3 ... column98 column99 column100];
[------- ------- " A " --- -------- " N " ---------]
[------- ------- " D " --- -------- " R " ---------]
[------- ------- " E " --- -------- " S " ---------]
[------- ------- " : " --- -------- " : " ---------]
[------- ------- " J " --- -------- " T " ---------]]"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open sample.csv
let actual = nu!(pipeline(&format!(
r#"
{sample}
| move column99 column3 --before column2
| rename _ chars_1 chars_2
| select chars_2 chars_1
| upsert new_col {|f| $f | transpose | get column1 | str trim | str join}
| upsert new_col {{|f| $f | transpose | get column1 | str trim | str join}}
| get new_col
| str join
"#
));
)));
assert!(actual.out.contains("ANDRES::JT"));
})
assert!(actual.out.contains("ANDRES::JT"));
}
#[test]
fn moves_a_column_after() {
Playground::setup("move_column_test_3", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"sample.csv",
r#"
column1,column2,letters,...,column98,and_more,column100
-------,-------, A ,---,--------, N ,---------
-------,-------, D ,---,--------, R ,---------
-------,-------, E ,---,--------, S ,---------
-------,-------, : ,---,--------, : ,---------
-------,-------, J ,---,--------, T ,---------
"#,
)]);
let sample = r#"
[[column1 column2 letters ... column98 and_more column100];
[------- ------- " A " --- -------- " N " ---------]
[------- ------- " D " --- -------- " R " ---------]
[------- ------- " E " --- -------- " S " ---------]
[------- ------- " : " --- -------- " : " ---------]
[------- ------- " J " --- -------- " T " ---------]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open sample.csv
let actual = nu!(pipeline(&format!(
r#"
{sample}
| move letters --after and_more
| move letters and_more --before column2
| rename _ chars_1 chars_2
| select chars_1 chars_2
| upsert new_col {|f| $f | transpose | get column1 | str trim | str join}
| upsert new_col {{|f| $f | transpose | get column1 | str trim | str join}}
| get new_col
| str join
"#
));
)));
assert!(actual.out.contains("ANDRES::JT"));
})
assert!(actual.out.contains("ANDRES::JT"));
}
#[test]
fn moves_columns_after() {
Playground::setup("move_column_test_4", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"sample.csv",
r#"
column1,column2,letters,...,column98,and_more,column100
-------,-------, A ,---,--------, N ,---------
-------,-------, D ,---,--------, R ,---------
-------,-------, E ,---,--------, S ,---------
-------,-------, : ,---,--------, : ,---------
-------,-------, J ,---,--------, T ,---------
"#,
)]);
let content = r#"
[[column1 column2 letters ... column98 and_more column100];
[------- ------- " A " --- -------- " N " ---------]
[------- ------- " D " --- -------- " R " ---------]
[------- ------- " E " --- -------- " S " ---------]
[------- ------- " : " --- -------- " : " ---------]
[------- ------- " J " --- -------- " T " ---------]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open sample.csv
let actual = nu!(pipeline(&format!(
r#"
{content}
| move letters and_more --after column1
| columns
| select 1 2
| str join
"#
));
)));
assert!(actual.out.contains("lettersand_more"));
})
assert!(actual.out.contains("lettersand_more"));
}