holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove file I/O from tests that don't need it (#11182)

Browse Source 
# Description

This PR implements modifications to command tests that write unnecessary
json and csv to disk then load it with open, by using nuon literals
instead.

- Fixes #7189



# User-Facing Changes
None

# Tests + Formatting
This only affects existing tests, which still pass.
This commit is contained in:
Renan Ribeiro
2023-11-29 19:21:34 -03:00
committed by GitHub
parent d08e254d16
commit 54d73748e4
20 changed files with 414 additions and 760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
crates/nu-command/tests/commands/rename.rs
View File

@ -1,116 +1,85 @@
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
use nu_test_support::playground::Playground;
use nu_test_support::{nu, pipeline};
#[test]
fn changes_the_column_name() {
Playground::setup("rename_test_1", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_cuatro_mosqueteros.txt",
r#"
Andrés N. Robalino
JT Turner
Yehuda Katz
Jason Gedge
"#,
)]);
let sample = r#"
[["Andrés N. Robalino"],
["JT Turner"],
["Yehuda Katz"],
["Jason Gedge"]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
"
open los_cuatro_mosqueteros.txt
| lines
let actual = nu!(pipeline(&format!(
" {sample}
| wrap name
| rename mosqueteros
| get mosqueteros
| length
"
));
)));
assert_eq!(actual.out, "4");
})
assert_eq!(actual.out, "4");
}
#[test]
fn keeps_remaining_original_names_given_less_new_names_than_total_original_names() {
Playground::setup("rename_test_2", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_cuatro_mosqueteros.txt",
r#"
Andrés N. Robalino
JT Turner
Yehuda Katz
Jason Gedge
"#,
)]);
let sample = r#"
[["Andrés N. Robalino"],
["JT Turner"],
["Yehuda Katz"],
["Jason Gedge"]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open los_cuatro_mosqueteros.txt
| lines
let actual = nu!(pipeline(&format!(
r#"
{sample}
| wrap name
| default "arepa!" hit
| rename mosqueteros
| get hit
| length
"#
));
)));
assert_eq!(actual.out, "4");
})
assert_eq!(actual.out, "4");
}
#[test]
fn errors_if_no_columns_present() {
Playground::setup("rename_test_3", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_cuatro_mosqueteros.txt",
r#"
Andrés N. Robalino
JT Turner
Yehuda Katz
Jason Gedge
"#,
)]);
let sample = r#"
[["Andrés N. Robalino"],
["JT Turner"],
["Yehuda Katz"],
["Jason Gedge"]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
"
open los_cuatro_mosqueteros.txt
| lines
let actual = nu!(pipeline(&format!(
"
{sample}
| rename mosqueteros
"
));
)));
assert!(actual.err.contains("command doesn't support"));
})
assert!(actual.err.contains("command doesn't support"));
}
#[test]
fn errors_if_columns_param_is_empty() {
Playground::setup("rename_test_4", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"los_cuatro_mosqueteros.txt",
r#"
Andrés N. Robalino
JT Turner
Yehuda Katz
Jason Gedge
"#,
)]);
let sample = r#"
[["Andrés N. Robalino"],
["JT Turner"],
["Yehuda Katz"],
["Jason Gedge"]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open los_cuatro_mosqueteros.txt
| lines
let actual = nu!(pipeline(&format!(
r#"
{sample}
| wrap name
| default "arepa!" hit
| rename --column {}
| rename --column {{}}
"#
));
)));
assert!(actual.err.contains("The column info cannot be empty"));
})
assert!(actual.err.contains("The column info cannot be empty"));
}