holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove file I/O from tests that don't need it (#11182)

Browse Source 
# Description

This PR implements modifications to command tests that write unnecessary
json and csv to disk then load it with open, by using nuon literals
instead.

- Fixes #7189



# User-Facing Changes
None

# Tests + Formatting
This only affects existing tests, which still pass.
This commit is contained in:
Renan Ribeiro
2023-11-29 19:21:34 -03:00
committed by GitHub
parent d08e254d16
commit 54d73748e4
20 changed files with 414 additions and 760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
crates/nu-command/tests/commands/take/while_.rs
View File

@ -1,53 +1,38 @@
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
use nu_test_support::playground::Playground;
use nu_test_support::{nu, pipeline};
#[test]
fn condition_is_met() {
Playground::setup("take_while_test_1", |dirs, sandbox| {
sandbox.with_files(vec![FileWithContentToBeTrimmed(
"caballeros.txt",
r#"
CHICKEN SUMMARY report date: April 29th, 2020
--------------------------------------------------------------------
Chicken Collection,29/04/2020,30/04/2020,31/04/2020
Yellow Chickens,,,
Andrés,1,1,1
JT,1,1,1
Jason,1,1,1
Yehuda,1,1,1
Blue Chickens,,,
Andrés,1,1,2
JT,1,1,2
Jason,1,1,2
Yehuda,1,1,2
Red Chickens,,,
Andrés,1,1,3
JT,1,1,3
Jason,1,1,3
Yehuda,1,1,3
"#,
)]);
let sample = r#"
[["Chicken Collection", "29/04/2020", "30/04/2020", "31/04/2020"];
["Yellow Chickens", "", "", ""],
[Andrés, 1, 1, 1],
[JT, 1, 1, 1],
[Jason, 1, 1, 1],
[Yehuda, 1, 1, 1],
["Blue Chickens", "", "", ""],
[Andrés, 1, 1, 2],
[JT, 1, 1, 2],
[Jason, 1, 1, 2],
[Yehuda, 1, 1, 2],
["Red Chickens", "", "", ""],
[Andrés, 1, 1, 3],
[JT, 1, 1, 3],
[Jason, 1, 1, 3],
[Yehuda, 1, 1, 3]]
"#;
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open --raw caballeros.txt
| lines
| skip 2
| str trim
| str join (char nl)
| from csv
let actual = nu!(pipeline(&format!(
r#"
{sample}
| skip 1
| take while {|row| $row."Chicken Collection" != "Blue Chickens"}
| take while {{|row| $row."Chicken Collection" != "Blue Chickens"}}
| into int "31/04/2020"
| get "31/04/2020"
| math sum
"#
));
)));
assert_eq!(actual.out, "4");
})
assert_eq!(actual.out, "4");
}
#[test]