forked from extern/nushell
Refactor first
and last
(#12478)
# Description - Refactors `first` and `last` using `Vec::truncate` and `Vec::drain`. - `std::mem::take` was also used to eliminate a few `Value` clones. - The `NeedsPositiveValue` error now uses the span of the `rows` argument instead of the call head span. - `last` now errors on an empty stream to match `first` which does error. - Made metadata preservation more consistent. # User-Facing Changes Breaking change: `last` now errors on an empty stream to match `first` which does error.
This commit is contained in:
@ -51,7 +51,7 @@ fn gets_first_row_when_no_amount_given() {
|
||||
fn gets_first_row_as_list_when_amount_given() {
|
||||
let actual = nu!("[1, 2, 3] | first 1 | describe");
|
||||
|
||||
assert_eq!(actual.out, "list<int> (stream)");
|
||||
assert_eq!(actual.out, "list<int>");
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
Reference in New Issue
Block a user