From 5c07e82fc01639576f65062724d67956e1df3065 Mon Sep 17 00:00:00 2001 From: Antoine Stevan <44101798+amtoine@users.noreply.github.com> Date: Sat, 2 Dec 2023 08:16:17 +0100 Subject: [PATCH] Remove list -> list (#11137) this should - close https://github.com/nushell/nushell/issues/11134 # Description this is band-aid... but it should address the issue in https://github.com/nushell/nushell/issues/11134 until we have a better long-term fix for this i/o types bug :innocent: # User-Facing Changes the following will now parse and run fine ```nushell def get-initial-commit []: nothing -> string { ^git rev-list HEAD | lines | last } ``` # Tests + Formatting # After Submitting --- crates/nu-command/src/filters/last.rs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/crates/nu-command/src/filters/last.rs b/crates/nu-command/src/filters/last.rs index 944ef5937..2a5135f8f 100644 --- a/crates/nu-command/src/filters/last.rs +++ b/crates/nu-command/src/filters/last.rs @@ -20,15 +20,6 @@ impl Command for Last { fn signature(&self) -> Signature { Signature::build("last") .input_output_types(vec![ - ( - // TODO: This variant duplicates the functionality of - // `take`. See #6611, #6611, #6893 - // TODO: This is too permissive; if we could express this - // using a type parameter style it would be List -> - // List. - Type::List(Box::new(Type::Any)), - Type::List(Box::new(Type::Any)), - ), ( // TODO: This is too permissive; if we could express this // using a type parameter it would be List -> T.