holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify todo/fixmes

Browse Source
This commit is contained in:
JT
2021-10-13 06:44:23 +13:00
parent 67b8438bda
commit 6024a001b4
18 changed files with 31 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/nu-command/src/conversions/into/binary.rs
View File

@ -93,7 +93,7 @@ fn into_binary(
input.map(head, move |v| {
action(v, head)
// FIXME: Add back in column path support
// FIXME: Add back in cell_path support
// if column_paths.is_empty() {
// action(v, head)
// } else {

2
crates/nu-command/src/default_context.rs
View File

@ -22,7 +22,7 @@ pub fn create_default_context() -> Rc<RefCell<EngineState>> {
};
}
// TODO: sort items categorically
// TODO: sort default context items categorically
bind_command!(
Alias,
Benchmark,

4
crates/nu-command/src/experimental/git.rs
View File

@ -37,13 +37,13 @@ impl Command for Git {
Ok(Value::string(&String::from_utf8_lossy(&result), call.head))
}
Err(_err) => {
// FIXME
// FIXME: Move this to an external signature and add better error handling
Ok(Value::nothing())
}
}
}
Err(_err) => {
// FIXME
// FIXME: Move this to an external signature and add better error handling
Ok(Value::nothing())
}
}

4
crates/nu-command/src/experimental/git_checkout.rs
View File

@ -52,13 +52,13 @@ impl Command for GitCheckout {
Ok(Value::string(&String::from_utf8_lossy(&result), call.head))
}
Err(_err) => {
// FIXME
// FIXME: Move this to an external signature and add better error handling
Ok(Value::nothing())
}
}
}
Err(_err) => {
// FIXME
// FIXME: Move this to an external signature and add better error handling
Ok(Value::nothing())
}
}

2
crates/nu-command/src/filesystem/mv.rs
View File

@ -37,7 +37,7 @@ impl Command for Mv {
call: &Call,
_input: Value,
) -> Result<nu_protocol::Value, nu_protocol::ShellError> {
// TODO: handle invalid directory or insufficient permissions
// TODO: handle invalid directory or insufficient permissions when moving
let source: String = call.req(context, 0)?;
let destination: String = call.req(context, 1)?;

3
crates/nu-command/src/filters/each.rs
View File

@ -217,7 +217,7 @@ impl Command for Each {
Value::Record {
mut cols, mut vals, ..
} => {
// TODO check that the lengths match
// TODO check that the lengths match when traversing record
output_cols.append(&mut cols);
output_vals.append(&mut vals);
}
@ -235,7 +235,6 @@ impl Command for Each {
})
}
x => {
//TODO: we need to watch to make sure this is okay
let engine_state = context.engine_state.borrow();
let block = engine_state.get_block(block_id);