Fix warnings and old names (#8457)

# Description

This fixes up some clippy warnings and removes some old names/info from
our unit tests

# User-Facing Changes

Internal changes only

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.

crates/nu-command/tests/commands/move_/column.rs

@@ -45,10 +45,7 @@ fn moves_columns_before() {
                 -------,-------,   D   ,---,--------,   R    ,---------
                 -------,-------,   E   ,---,--------,   S    ,---------
                 -------,-------,   :   ,---,--------,   :    ,---------
-                -------,-------,   J   ,---,--------,   O    ,---------
-                -------,-------,   N   ,---,--------,   A    ,---------
-                -------,-------,   T   ,---,--------,   H    ,---------
-                -------,-------,   A   ,---,--------,   N    ,---------
+                -------,-------,   J   ,---,--------,   T    ,---------
             "#,
         )]);
 
@@ -65,7 +62,7 @@ fn moves_columns_before() {
             "#
         ));
 
-        assert!(actual.out.contains("ANDRES::JONATHAN"));
+        assert!(actual.out.contains("ANDRES::JT"));
     })
 }
 
@@ -80,10 +77,7 @@ fn moves_a_column_after() {
                 -------,-------,   D   ,---,--------,   R    ,---------
                 -------,-------,   E   ,---,--------,   S    ,---------
                 -------,-------,   :   ,---,--------,   :    ,---------
-                -------,-------,   J   ,---,--------,   O    ,---------
-                -------,-------,   N   ,---,--------,   A    ,---------
-                -------,-------,   T   ,---,--------,   H    ,---------
-                -------,-------,   A   ,---,--------,   N    ,---------
+                -------,-------,   J   ,---,--------,   T    ,---------
             "#,
         )]);
 
@@ -101,7 +95,7 @@ fn moves_a_column_after() {
             "#
         ));
 
-        assert!(actual.out.contains("ANDRES::JONATHAN"));
+        assert!(actual.out.contains("ANDRES::JT"));
     })
 }
 
@@ -116,10 +110,7 @@ fn moves_columns_after() {
                 -------,-------,   D   ,---,--------,   R    ,---------
                 -------,-------,   E   ,---,--------,   S    ,---------
                 -------,-------,   :   ,---,--------,   :    ,---------
-                -------,-------,   J   ,---,--------,   O    ,---------
-                -------,-------,   N   ,---,--------,   A    ,---------
-                -------,-------,   T   ,---,--------,   H    ,---------
-                -------,-------,   A   ,---,--------,   N    ,---------
+                -------,-------,   J   ,---,--------,   T    ,---------
             "#,
         )]);
 

crates/nu-command/tests/commands/move_/mv.rs

@@ -25,14 +25,14 @@ fn moves_a_file() {
 #[test]
 fn overwrites_if_moving_to_existing_file_and_force_provided() {
     Playground::setup("mv_test_2", |dirs, sandbox| {
-        sandbox.with_files(vec![EmptyFile("andres.txt"), EmptyFile("jonathan.txt")]);
+        sandbox.with_files(vec![EmptyFile("andres.txt"), EmptyFile("jttxt")]);
 
         let original = dirs.test().join("andres.txt");
-        let expected = dirs.test().join("jonathan.txt");
+        let expected = dirs.test().join("jttxt");
 
         nu!(
             cwd: dirs.test(),
-            "mv andres.txt -f jonathan.txt"
+            "mv andres.txt -f jttxt"
         );
 
         assert!(!original.exists());
@@ -62,15 +62,15 @@ fn moves_a_directory() {
 fn moves_the_file_inside_directory_if_path_to_move_is_existing_directory() {
     Playground::setup("mv_test_4", |dirs, sandbox| {
         sandbox
-            .with_files(vec![EmptyFile("jonathan.txt")])
+            .with_files(vec![EmptyFile("jttxt")])
             .mkdir("expected");
 
-        let original_dir = dirs.test().join("jonathan.txt");
-        let expected = dirs.test().join("expected/jonathan.txt");
+        let original_dir = dirs.test().join("jttxt");
+        let expected = dirs.test().join("expected/jttxt");
 
         nu!(
             cwd: dirs.test(),
-            "mv jonathan.txt expected"
+            "mv jttxt expected"
         );
 
         assert!(!original_dir.exists());
@@ -83,7 +83,7 @@ fn moves_the_directory_inside_directory_if_path_to_move_is_existing_directory()
     Playground::setup("mv_test_5", |dirs, sandbox| {
         sandbox
             .within("contributors")
-            .with_files(vec![EmptyFile("jonathan.txt")])
+            .with_files(vec![EmptyFile("jttxt")])
             .mkdir("expected");
 
         let original_dir = dirs.test().join("contributors");
@@ -96,7 +96,7 @@ fn moves_the_directory_inside_directory_if_path_to_move_is_existing_directory()
 
         assert!(!original_dir.exists());
         assert!(expected.exists());
-        assert!(files_exist_at(vec!["jonathan.txt"], expected))
+        assert!(files_exist_at(vec!["jttxt"], expected))
     })
 }
 
@@ -109,8 +109,8 @@ fn moves_using_path_with_wildcard() {
                 EmptyFile("andres.ini"),
                 EmptyFile("caco3_plastics.csv"),
                 EmptyFile("cargo_sample.toml"),
-                EmptyFile("jonathan.ini"),
-                EmptyFile("jonathan.xml"),
+                EmptyFile("jt.ini"),
+                EmptyFile("jt.xml"),
                 EmptyFile("sgml_description.json"),
                 EmptyFile("sample.ini"),
                 EmptyFile("utf16.ini"),
@@ -125,7 +125,7 @@ fn moves_using_path_with_wildcard() {
         nu!(cwd: work_dir, "mv ../originals/*.ini ../expected");
 
         assert!(files_exist_at(
-            vec!["yehuda.ini", "jonathan.ini", "sample.ini", "andres.ini",],
+            vec!["yehuda.ini", "jt.ini", "sample.ini", "andres.ini",],
             expected
         ));
     })
@@ -210,11 +210,11 @@ fn errors_if_source_doesnt_exist() {
 #[test]
 fn error_if_moving_to_existing_file_without_force() {
     Playground::setup("mv_test_10_0", |dirs, sandbox| {
-        sandbox.with_files(vec![EmptyFile("andres.txt"), EmptyFile("jonathan.txt")]);
+        sandbox.with_files(vec![EmptyFile("andres.txt"), EmptyFile("jttxt")]);
 
         let actual = nu!(
             cwd: dirs.test(),
-            "mv andres.txt jonathan.txt"
+            "mv andres.txt jttxt"
         );
         assert!(actual.err.contains("file already exists"))
     })
@@ -309,7 +309,7 @@ fn does_not_error_on_relative_parent_path() {
 fn move_files_using_glob_two_parents_up_using_multiple_dots() {
     Playground::setup("mv_test_12", |dirs, sandbox| {
         sandbox.within("foo").within("bar").with_files(vec![
-            EmptyFile("jonathan.json"),
+            EmptyFile("jtjson"),
             EmptyFile("andres.xml"),
             EmptyFile("yehuda.yaml"),
             EmptyFile("kevin.txt"),
@@ -325,7 +325,7 @@ fn move_files_using_glob_two_parents_up_using_multiple_dots() {
 
         let files = vec![
             "yehuda.yaml",
-            "jonathan.json",
+            "jtjson",
             "andres.xml",
             "kevin.txt",
             "many_more.ppl",