holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up tests containing unnecessary cwd: tokens (#9692)

Browse Source 
# Description
The working directory doesn't have to be set for those tests (or would
be the default anyways). When appropriate also remove calls to the
`pipeline()` function. In most places kept the diff minimal and only
removed the superfluous part to not pollute the blame view. With simpler
tests also simplified things to make them more readable overall (this
included removal of the raw string literal).

Work for #8670
This commit is contained in:
Stefan Holderbach
2023-07-17 18:43:51 +02:00
committed by GitHub
parent 48271d8c3e
commit 656f707a0b
70 changed files with 611 additions and 1344 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
crates/nu-command/tests/commands/with_env.rs
View File

@@ -2,97 +2,71 @@ use nu_test_support::nu;
#[test]
fn with_env_extends_environment() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"with-env [FOO BARRRR] {echo $env} | get FOO"
);
let actual = nu!("with-env [FOO BARRRR] {echo $env} | get FOO");
assert_eq!(actual.out, "BARRRR");
}
#[test]
fn with_env_shorthand() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"FOO=BARRRR echo $env | get FOO"
);
let actual = nu!("FOO=BARRRR echo $env | get FOO");
assert_eq!(actual.out, "BARRRR");
}
#[test]
fn shorthand_doesnt_reorder_arguments() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"FOO=BARRRR nu --testbin cococo first second"
);
let actual = nu!("FOO=BARRRR nu --testbin cococo first second");
assert_eq!(actual.out, "first second");
}
#[test]
fn with_env_shorthand_trims_quotes() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"FOO='BARRRR' echo $env | get FOO"
);
let actual = nu!("FOO='BARRRR' echo $env | get FOO");
assert_eq!(actual.out, "BARRRR");
}
#[test]
fn with_env_and_shorthand_same_result() {
let actual_shorthand = nu!(
cwd: "tests/fixtures/formats",
"FOO='BARRRR' echo $env | get FOO"
);
let actual_shorthand = nu!("FOO='BARRRR' echo $env | get FOO");
let actual_normal = nu!(
cwd: "tests/fixtures/formats",
"with-env [FOO BARRRR] {echo $env} | get FOO"
);
let actual_normal = nu!("with-env [FOO BARRRR] {echo $env} | get FOO");
assert_eq!(actual_shorthand.out, actual_normal.out);
}
#[test]
fn test_redirection2() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"let x = (FOO=BAR nu --testbin cococo niceenvvar); $x | str trim | str length"
);
let actual =
nu!("let x = (FOO=BAR nu --testbin cococo niceenvvar); $x | str trim | str length");
assert_eq!(actual.out, "10");
}
#[test]
fn with_env_hides_variables_in_parent_scope() {
let actual = nu!(
cwd: "tests/fixtures/formats",
r#"
let actual = nu!(r#"
$env.FOO = "1"
print $env.FOO
with-env [FOO null] {
echo $env.FOO
}
print $env.FOO
"#
);
"#);
assert_eq!(actual.out, "11");
}
#[test]
fn with_env_shorthand_can_not_hide_variables() {
let actual = nu!(
cwd: "tests/fixtures/formats",
r#"
let actual = nu!(r#"
$env.FOO = "1"
print $env.FOO
FOO=null print $env.FOO
print $env.FOO
"#
);
"#);
assert_eq!(actual.out, "1null1");
}