From 6cc66c8afde6f2e81bca0bf02c359283afc26b6d Mon Sep 17 00:00:00 2001 From: WindSoilder Date: Sat, 7 May 2022 19:23:49 +0800 Subject: [PATCH] complete some commands tests (#5464) * complete hash test * unignore source relative tests --- crates/nu-command/tests/commands/hash_/mod.rs | 4 ---- crates/nu-command/tests/commands/source.rs | 4 ---- 2 files changed, 8 deletions(-) diff --git a/crates/nu-command/tests/commands/hash_/mod.rs b/crates/nu-command/tests/commands/hash_/mod.rs index 230b93ce7..51840b385 100644 --- a/crates/nu-command/tests/commands/hash_/mod.rs +++ b/crates/nu-command/tests/commands/hash_/mod.rs @@ -26,8 +26,6 @@ fn base64_encode_characterset_binhex() { assert_eq!(actual.out, "F@0NEPjJD97kE\'&bEhFZEP3"); } -// FIXME: jt: needs more work -#[ignore] #[test] fn error_when_invalid_character_set_given() { let actual = nu!( @@ -43,8 +41,6 @@ fn error_when_invalid_character_set_given() { .contains("this is invalid is not a valid character-set")); } -// FIXME: jt: needs more work -#[ignore] #[test] fn base64_decode_characterset_binhex() { let actual = nu!( diff --git a/crates/nu-command/tests/commands/source.rs b/crates/nu-command/tests/commands/source.rs index 5824d4ada..b663f1cfb 100644 --- a/crates/nu-command/tests/commands/source.rs +++ b/crates/nu-command/tests/commands/source.rs @@ -123,8 +123,6 @@ fn sources_unicode_file_in_unicode_dir_without_spaces_2() { try_source_foo_without_quotes_in(":fire_engine:", "source_test_9"); } -// FIXME: jt: needs more work -#[ignore] #[test] fn sources_unicode_file_in_unicode_dir_with_spaces_1() { // this one fails @@ -133,8 +131,6 @@ fn sources_unicode_file_in_unicode_dir_with_spaces_1() { try_source_foo_with_double_quotes_in("e-$ Γ¨Ρ€Ρ‚πŸš’β™žδΈ­η‰‡-j", "source_test_9"); } -// FIXME: jt: needs more work -#[ignore] #[cfg(not(windows))] // ':' is not allowed in Windows paths #[test] fn sources_unicode_file_in_unicode_dir_with_spaces_2() {