Move Value to helpers, separate span call (#10121)

# Description

As part of the refactor to split spans off of Value, this moves to using
helper functions to create values, and using `.span()` instead of
matching span out of Value directly.

Hoping to get a few more helping hands to finish this, as there are a
lot of commands to update :)

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->

---------

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
Co-authored-by: WindSoilder <windsoilder@outlook.com>

crates/nu-cmd-dataframe/src/dataframe/series/date/as_datetime.rs

@@ -56,22 +56,22 @@ impl Command for AsDateTime {
                     NuDataFrame::try_from_columns(vec![Column::new(
                         "datetime".to_string(),
                         vec![
-                            Value::Date {
-                                val: DateTime::parse_from_str(
+                            Value::date(
+                                DateTime::parse_from_str(
                                     "2021-12-30 00:00:00 +0000",
                                     "%Y-%m-%d %H:%M:%S %z",
                                 )
                                 .expect("date calculation should not fail in test"),
-                                span: Span::test_data(),
-                            },
-                            Value::Date {
-                                val: DateTime::parse_from_str(
+                                Span::test_data(),
+                            ),
+                            Value::date(
+                                DateTime::parse_from_str(
                                     "2021-12-31 00:00:00 +0000",
                                     "%Y-%m-%d %H:%M:%S %z",
                                 )
                                 .expect("date calculation should not fail in test"),
-                                span: Span::test_data(),
-                            },
+                                Span::test_data(),
+                            ),
                         ],
                     )])
                     .expect("simple df for test should not fail")
@@ -85,22 +85,22 @@ impl Command for AsDateTime {
                     NuDataFrame::try_from_columns(vec![Column::new(
                         "datetime".to_string(),
                         vec![
-                            Value::Date {
-                                val: DateTime::parse_from_str(
+                            Value::date(
+                                DateTime::parse_from_str(
                                     "2021-12-30 00:00:00.123456789 +0000",
                                     "%Y-%m-%d %H:%M:%S.%9f %z",
                                 )
                                 .expect("date calculation should not fail in test"),
-                                span: Span::test_data(),
-                            },
-                            Value::Date {
-                                val: DateTime::parse_from_str(
+                                Span::test_data(),
+                            ),
+                            Value::date(
+                                DateTime::parse_from_str(
                                     "2021-12-31 00:00:00.123456789 +0000",
                                     "%Y-%m-%d %H:%M:%S.%9f %z",
                                 )
                                 .expect("date calculation should not fail in test"),
-                                span: Span::test_data(),
-                            },
+                                Span::test_data(),
+                            ),
                         ],
                     )])
                     .expect("simple df for test should not fail")

crates/nu-cmd-dataframe/src/dataframe/series/indexes/set_with_idx.rs

@@ -123,8 +123,9 @@ fn command(
     let df = NuDataFrame::try_from_pipeline(input, call.head)?;
     let series = df.as_series(call.head)?;
 
+    let span = value.span();
     let res = match value {
-        Value::Int { val, span } => {
+        Value::Int { val, .. } => {
             let chunked = series.i64().map_err(|e| {
                 ShellError::GenericError(
                     "Error casting to i64".into(),
@@ -147,7 +148,7 @@ fn command(
 
             NuDataFrame::try_from_series(vec![res.into_series()], call.head)
         }
-        Value::Float { val, span } => {
+        Value::Float { val, .. } => {
             let chunked = series.f64().map_err(|e| {
                 ShellError::GenericError(
                     "Error casting to f64".into(),
@@ -170,7 +171,7 @@ fn command(
 
             NuDataFrame::try_from_series(vec![res.into_series()], call.head)
         }
-        Value::String { val, span } => {
+        Value::String { val, .. } => {
             let chunked = series.utf8().map_err(|e| {
                 ShellError::GenericError(
                     "Error casting to string".into(),
@@ -204,7 +205,7 @@ fn command(
                 "this value cannot be set in a series of type '{}'",
                 series.dtype()
             ),
-            Some(value.span()),
+            Some(span),
             None,
             Vec::new(),
         )),

crates/nu-cmd-dataframe/src/dataframe/series/masks/set.rs

@@ -105,9 +105,9 @@ fn command(
 
     let df = NuDataFrame::try_from_pipeline(input, call.head)?;
     let series = df.as_series(call.head)?;
-
+    let span = value.span();
     let res = match value {
-        Value::Int { val, span } => {
+        Value::Int { val, .. } => {
             let chunked = series.i64().map_err(|e| {
                 ShellError::GenericError(
                     "Error casting to i64".into(),
@@ -130,7 +130,7 @@ fn command(
 
             NuDataFrame::try_from_series(vec![res.into_series()], call.head)
         }
-        Value::Float { val, span } => {
+        Value::Float { val, .. } => {
             let chunked = series.f64().map_err(|e| {
                 ShellError::GenericError(
                     "Error casting to f64".into(),
@@ -153,7 +153,7 @@ fn command(
 
             NuDataFrame::try_from_series(vec![res.into_series()], call.head)
         }
-        Value::String { val, span } => {
+        Value::String { val, .. } => {
             let chunked = series.utf8().map_err(|e| {
                 ShellError::GenericError(
                     "Error casting to string".into(),
@@ -185,7 +185,7 @@ fn command(
                 "this value cannot be set in a series of type '{}'",
                 series.dtype()
             ),
-            Some(value.span()),
+            Some(span),
             None,
             Vec::new(),
         )),