forked from extern/nushell
rename the types with spaces in them to use -
(#9929)
# Description before this PR, ```nushell > $.a.b | describe cell path ``` which feels inconsistent with the `cell-path` type annotation, like in ```nushell > def foo [x: cell-path] { $x | describe }; foo $.a.b cell path ``` this PR changes the name of the "cell path" type from `cell path` to `cell-path` # User-Facing Changes `cell path` is now `cell-path` in the output of `describe`. this might be a breaking change in some scripts. same goes with - `list stream` -> `list-stream` - `match pattern` -> `match-pattern` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - ⚫ `toolkit test` - ⚫ `toolkit test stdlib` this PR adds a new `cell_path_type` test to make sure it stays equal to `cell-path` in the future. # After Submitting --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
This commit is contained in:
@ -184,8 +184,8 @@ impl Display for SyntaxShape {
|
||||
}
|
||||
SyntaxShape::Any => write!(f, "any"),
|
||||
SyntaxShape::String => write!(f, "string"),
|
||||
SyntaxShape::CellPath => write!(f, "cellpath"),
|
||||
SyntaxShape::FullCellPath => write!(f, "cellpath"),
|
||||
SyntaxShape::CellPath => write!(f, "cell-path"),
|
||||
SyntaxShape::FullCellPath => write!(f, "cell-path"),
|
||||
SyntaxShape::Number => write!(f, "number"),
|
||||
SyntaxShape::Range => write!(f, "range"),
|
||||
SyntaxShape::Int => write!(f, "int"),
|
||||
@ -229,8 +229,8 @@ impl Display for SyntaxShape {
|
||||
SyntaxShape::Variable => write!(f, "var"),
|
||||
SyntaxShape::VarWithOptType => write!(f, "vardecl"),
|
||||
SyntaxShape::Signature => write!(f, "signature"),
|
||||
SyntaxShape::MatchPattern => write!(f, "matchpattern"),
|
||||
SyntaxShape::MatchBlock => write!(f, "matchblock"),
|
||||
SyntaxShape::MatchPattern => write!(f, "match-pattern"),
|
||||
SyntaxShape::MatchBlock => write!(f, "match-block"),
|
||||
SyntaxShape::Expression => write!(f, "expression"),
|
||||
SyntaxShape::Boolean => write!(f, "bool"),
|
||||
SyntaxShape::Error => write!(f, "error"),
|
||||
|
@ -121,7 +121,7 @@ impl Type {
|
||||
Type::Block => String::from("block"),
|
||||
Type::Closure => String::from("closure"),
|
||||
Type::Bool => String::from("bool"),
|
||||
Type::CellPath => String::from("cell path"),
|
||||
Type::CellPath => String::from("cell-path"),
|
||||
Type::Date => String::from("date"),
|
||||
Type::Duration => String::from("duration"),
|
||||
Type::Filesize => String::from("filesize"),
|
||||
@ -131,11 +131,11 @@ impl Type {
|
||||
Type::Record(_) => String::from("record"),
|
||||
Type::Table(_) => String::from("table"),
|
||||
Type::List(_) => String::from("list"),
|
||||
Type::MatchPattern => String::from("match pattern"),
|
||||
Type::MatchPattern => String::from("match-pattern"),
|
||||
Type::Nothing => String::from("nothing"),
|
||||
Type::Number => String::from("number"),
|
||||
Type::String => String::from("string"),
|
||||
Type::ListStream => String::from("list stream"),
|
||||
Type::ListStream => String::from("list-stream"),
|
||||
Type::Any => String::from("any"),
|
||||
Type::Error => String::from("error"),
|
||||
Type::Binary => String::from("binary"),
|
||||
@ -151,7 +151,7 @@ impl Display for Type {
|
||||
Type::Block => write!(f, "block"),
|
||||
Type::Closure => write!(f, "closure"),
|
||||
Type::Bool => write!(f, "bool"),
|
||||
Type::CellPath => write!(f, "cell path"),
|
||||
Type::CellPath => write!(f, "cell-path"),
|
||||
Type::Date => write!(f, "date"),
|
||||
Type::Duration => write!(f, "duration"),
|
||||
Type::Filesize => write!(f, "filesize"),
|
||||
@ -192,13 +192,13 @@ impl Display for Type {
|
||||
Type::Nothing => write!(f, "nothing"),
|
||||
Type::Number => write!(f, "number"),
|
||||
Type::String => write!(f, "string"),
|
||||
Type::ListStream => write!(f, "list stream"),
|
||||
Type::ListStream => write!(f, "list-stream"),
|
||||
Type::Any => write!(f, "any"),
|
||||
Type::Error => write!(f, "error"),
|
||||
Type::Binary => write!(f, "binary"),
|
||||
Type::Custom(custom) => write!(f, "{custom}"),
|
||||
Type::Signature => write!(f, "signature"),
|
||||
Type::MatchPattern => write!(f, "match pattern"),
|
||||
Type::MatchPattern => write!(f, "match-pattern"),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
@ -518,7 +518,7 @@ impl Value {
|
||||
match self {
|
||||
Value::MatchPattern { val, .. } => Ok(val.as_ref()),
|
||||
x => Err(ShellError::CantConvert {
|
||||
to_type: "match pattern".into(),
|
||||
to_type: "match-pattern".into(),
|
||||
from_type: x.get_type().to_string(),
|
||||
span: self.span(),
|
||||
help: None,
|
||||
|
Reference in New Issue
Block a user