forked from extern/nushell
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -113,11 +113,11 @@ fn parses_more_bson_complexity() {
|
||||
fn parses_sqlite() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
open sample.db
|
||||
| columns
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "3");
|
||||
@ -128,11 +128,11 @@ fn parses_sqlite() {
|
||||
fn parses_sqlite_get_column_name() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
open sample.db
|
||||
| get strings
|
||||
| get x.0
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "hello");
|
||||
@ -152,11 +152,11 @@ fn parses_toml() {
|
||||
fn parses_tsv() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
open caco3_plastics.tsv
|
||||
| first
|
||||
| get origin
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "SPAIN")
|
||||
@ -166,10 +166,10 @@ fn parses_tsv() {
|
||||
fn parses_json() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
open sgml_description.json
|
||||
| get glossary.GlossDiv.GlossList.GlossEntry.GlossSee
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "markup")
|
||||
@ -179,7 +179,7 @@ fn parses_json() {
|
||||
fn parses_xml() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats",
|
||||
pipeline(r#"
|
||||
pipeline("
|
||||
open jt.xml
|
||||
| get content
|
||||
| where tag == channel
|
||||
@ -190,7 +190,7 @@ fn parses_xml() {
|
||||
| flatten
|
||||
| where tag == guid
|
||||
| get content.0.content.0
|
||||
"#)
|
||||
")
|
||||
);
|
||||
|
||||
assert_eq!(actual.out, "https://www.jntrnr.com/off-to-new-adventures/")
|
||||
@ -201,12 +201,12 @@ fn parses_xml() {
|
||||
fn parses_arrow_ipc() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
dfr open caco3_plastics.arrow
|
||||
| dfr into-nu
|
||||
| first
|
||||
| get origin
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "SPAIN")
|
||||
@ -236,9 +236,9 @@ fn errors_if_file_not_found() {
|
||||
fn open_wildcard() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
open *.nu | where $it =~ echo | length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "3")
|
||||
@ -248,9 +248,9 @@ fn open_wildcard() {
|
||||
fn open_multiple_files() {
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
r#"
|
||||
"
|
||||
open caco3_plastics.csv caco3_plastics.tsv | get tariff_item | math sum
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "58309279992")
|
||||
@ -280,9 +280,9 @@ fn open_ignore_ansi() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls | find nu.zion | get 0 | get name | open $in
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -291,9 +291,7 @@ fn open_ignore_ansi() {
|
||||
|
||||
#[test]
|
||||
fn open_no_parameter() {
|
||||
let actual = nu!(r#"
|
||||
open
|
||||
"#);
|
||||
let actual = nu!("open");
|
||||
|
||||
assert!(actual.err.contains("needs filename"));
|
||||
}
|
||||
|
Reference in New Issue
Block a user