forked from extern/nushell
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -18,11 +18,11 @@ fn reduce_table_column() {
|
||||
#[test]
|
||||
fn reduce_table_column_with_path() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
"
|
||||
[{month:2,total:30}, {month:3,total:10}, {month:4,total:3}, {month:5,total:60}]
|
||||
| reduce -f 20 { |it, acc| $it.total + $acc ** 1.05}
|
||||
| into string -d 1
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "180.6");
|
||||
@ -31,10 +31,10 @@ fn reduce_table_column_with_path() {
|
||||
#[test]
|
||||
fn reduce_rows_example() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
"
|
||||
[[a,b]; [1,2] [3,4]]
|
||||
| reduce -f 1.6 { |it, acc| $acc * ($it.a | into int) + ($it.b | into int) }
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "14.8");
|
||||
@ -43,14 +43,14 @@ fn reduce_rows_example() {
|
||||
#[test]
|
||||
fn reduce_with_return_in_closure() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
"
|
||||
[1, 2] | reduce --fold null { |it, state|
|
||||
if $it == 1 {
|
||||
return 10
|
||||
};
|
||||
return ($it * $state)
|
||||
}
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "20");
|
||||
@ -60,11 +60,11 @@ fn reduce_with_return_in_closure() {
|
||||
#[test]
|
||||
fn reduce_enumerate_example() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
"
|
||||
echo one longest three bar | enumerate
|
||||
| reduce { |it, acc| if ($it.item | str length) > ($acc.item | str length) {echo $it} else {echo $acc}}
|
||||
| get index
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "1");
|
||||
@ -73,12 +73,12 @@ fn reduce_enumerate_example() {
|
||||
#[test]
|
||||
fn reduce_enumerate_integer_addition_example() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
"
|
||||
echo [1 2 3 4]
|
||||
| enumerate
|
||||
| reduce { |it, acc| { index: ($it.index) item: ($acc.item + $it.item)} }
|
||||
| get item
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "10");
|
||||
@ -87,7 +87,7 @@ fn reduce_enumerate_integer_addition_example() {
|
||||
#[test]
|
||||
fn folding_with_tables() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
"
|
||||
echo [10 20 30 40]
|
||||
| reduce -f [] { |it, acc|
|
||||
with-env [value $it] {
|
||||
@ -95,7 +95,7 @@ fn folding_with_tables() {
|
||||
}
|
||||
}
|
||||
| math sum
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "1000");
|
||||
@ -104,9 +104,7 @@ fn folding_with_tables() {
|
||||
#[test]
|
||||
fn error_reduce_fold_type_mismatch() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
echo a b c | reduce -f 0 { |it, acc| $acc + $it }
|
||||
"#
|
||||
"echo a b c | reduce -f 0 { |it, acc| $acc + $it }"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("mismatch"));
|
||||
@ -114,11 +112,7 @@ fn error_reduce_fold_type_mismatch() {
|
||||
|
||||
#[test]
|
||||
fn error_reduce_empty() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
reduce { |it, acc| $acc + $it }
|
||||
"#
|
||||
));
|
||||
let actual = nu!(pipeline("reduce { |it, acc| $acc + $it }"));
|
||||
|
||||
assert!(actual.err.contains("needs input"));
|
||||
}
|
||||
@ -126,9 +120,7 @@ fn error_reduce_empty() {
|
||||
#[test]
|
||||
fn enumerate_reduce_example() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
[one longest three bar] | enumerate | reduce {|it, acc| if ($it.item | str length) > ($acc.item | str length) { $it } else { $acc }} | get index
|
||||
"#
|
||||
"[one longest three bar] | enumerate | reduce {|it, acc| if ($it.item | str length) > ($acc.item | str length) { $it } else { $acc }} | get index"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "1");
|
||||
|
Reference in New Issue
Block a user