forked from extern/nushell
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -30,7 +30,7 @@ fn writes_out_list() {
|
||||
|
||||
nu!(
|
||||
cwd: dirs.root(),
|
||||
r#"[a b c d] | save save_test_3/list_sample.txt"#,
|
||||
"[a b c d] | save save_test_3/list_sample.txt",
|
||||
);
|
||||
|
||||
let actual = file_contents(expected_file);
|
||||
@ -185,7 +185,7 @@ fn save_failure_not_overrides() {
|
||||
nu!(
|
||||
cwd: dirs.root(),
|
||||
// Writing number to file as toml fails
|
||||
r#"3 | save save_test_10/result.toml -f"#
|
||||
"3 | save save_test_10/result.toml -f"
|
||||
);
|
||||
let actual = file_contents(expected_file);
|
||||
assert_eq!(actual, "Old content");
|
||||
@ -272,7 +272,7 @@ fn save_list_stream() {
|
||||
|
||||
nu!(
|
||||
cwd: dirs.root(),
|
||||
r#"[a b c d] | each {|i| $i} | save -r save_test_13/list_sample.txt"#,
|
||||
"[a b c d] | each {|i| $i} | save -r save_test_13/list_sample.txt",
|
||||
);
|
||||
|
||||
let actual = file_contents(expected_file);
|
||||
@ -289,7 +289,7 @@ fn writes_out_range() {
|
||||
|
||||
nu!(
|
||||
cwd: dirs.root(),
|
||||
r#"1..3 | save save_test_14/list_sample.json"#,
|
||||
"1..3 | save save_test_14/list_sample.json",
|
||||
);
|
||||
|
||||
let actual = file_contents(expected_file);
|
||||
|
Reference in New Issue
Block a user