forked from extern/nushell
Cut down on unnecessary parsing for SyntaxShape::Any (#9280)
# Description This removes some unnecessary SyntaxShapes when parsing a SyntaxShape::Any. Recent updates to the parser look for `{` and then handle the logic for that separately. # User-Facing Changes This may have a slight parser speedup. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -1368,7 +1368,7 @@ pub fn parse_export_in_module(
|
||||
}
|
||||
_ => {
|
||||
working_set.error(ParseError::Expected(
|
||||
"def, def-env, alias, use, module, or extern keyword".into(),
|
||||
"def, def-env, alias, use, module, or extern keyword",
|
||||
spans[1],
|
||||
));
|
||||
|
||||
@ -1713,7 +1713,7 @@ pub fn parse_module_block(
|
||||
} => block.pipelines.push(garbage_pipeline(&command.parts)),
|
||||
}
|
||||
} else {
|
||||
working_set.error(ParseError::Expected("not a pipeline".into(), span));
|
||||
working_set.error(ParseError::Expected("not a pipeline", span));
|
||||
block.pipelines.push(garbage_pipeline(&[span]))
|
||||
}
|
||||
}
|
||||
@ -2042,7 +2042,7 @@ pub fn parse_module(
|
||||
if block_bytes.starts_with(b"{") {
|
||||
start += 1;
|
||||
} else {
|
||||
working_set.error(ParseError::Expected("block".into(), block_span));
|
||||
working_set.error(ParseError::Expected("block", block_span));
|
||||
return (garbage_pipeline(spans), None);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user