From 9261c0c55aa21510d7f6b95327b76fa2178f3dfa Mon Sep 17 00:00:00 2001 From: Ian Manske Date: Thu, 22 Aug 2024 02:39:21 -0700 Subject: [PATCH] Be explicit about `reduce` args and input (#13646) # Description `run_with_value` is meant for running simple closures with one arg. Using `run_with_value` after `add_arg` is slightly confusing. --- crates/nu-command/src/filters/reduce.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/nu-command/src/filters/reduce.rs b/crates/nu-command/src/filters/reduce.rs index 4fca1df3a4..ffd2e850d9 100644 --- a/crates/nu-command/src/filters/reduce.rs +++ b/crates/nu-command/src/filters/reduce.rs @@ -120,7 +120,8 @@ impl Command for Reduce { engine_state.signals().check(head)?; acc = closure .add_arg(value) - .run_with_value(acc)? + .add_arg(acc.clone()) + .run_with_input(PipelineData::Value(acc, None))? .into_value(head)?; }