holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show error when trying to sort by invalid column (#1880)

Browse Source 
* Show error when trying to sort by invalid column

* Added test for changes

* Addressed comments, updated test

* Removed unnecessary mutable keyword

* Changed split-column to solt column after rebase from upstream
This commit is contained in:
Shaarad Dalvi
2020-05-24 23:07:08 +05:30
committed by GitHub
parent d488fddfe1
commit 9c14fb6c02
2 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/nu-cli/src/commands/sort_by.rs
View File

@ -69,6 +69,18 @@ fn sort_by(args: CommandArgs, registry: &CommandRegistry) -> Result<OutputStream
return;
}
for sort_arg in rest.iter() {
let match_test = get_data_by_key(&vec[0], sort_arg.borrow_spanned());
if match_test == None {
yield Err(ShellError::labeled_error(
"Can not find column to sort by",
"invalid column",
sort_arg.borrow_spanned().span,
));
return;
}
}
match &vec[0] {
Value {
value: UntaggedValue::Primitive(_),