holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Testing support tweaks: exit status in Outcome (#10692)

Browse Source 
This PR makes a couple of tweaks to the testing support crate:

Add the `nu` invocation's exit status to the test output so that one
can assert that nu exited with a successful code.

This PR was split off of #10232.
This commit is contained in:
Skyler Hawthorne 2023-11-15 17:50:43 -05:00 committed by GitHub
parent 2b5f1ee5b3
commit a806717f35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/nu-test-support/src/lib.rs
View File

@ -3,12 +3,15 @@ pub mod fs;
pub mod locale_override;
pub mod macros;
pub mod playground;
use std::process::ExitStatus;
// Needs to be reexported for `nu!` macro
pub use nu_path;
pub struct Outcome {
pub out: String,
pub err: String,
pub status: ExitStatus,
}
#[cfg(windows)]
@ -22,8 +25,8 @@ pub const NATIVE_PATH_ENV_SEPARATOR: char = ';';
pub const NATIVE_PATH_ENV_SEPARATOR: char = ':';
impl Outcome {
pub fn new(out: String, err: String) -> Outcome {
Outcome { out, err }
pub fn new(out: String, err: String, status: ExitStatus) -> Outcome {
Outcome { out, err, status }
}
}

4
crates/nu-test-support/src/macros.rs
View File

@ -279,7 +279,7 @@ pub fn nu_run_test(opts: NuOpts, commands: impl AsRef<str>, with_std: bool) -> O
println!("=== stderr\n{}", err);
Outcome::new(out, err.into_owned())
Outcome::new(out, err.into_owned(), output.status)
}
pub fn nu_with_plugin_run_test(cwd: impl AsRef<Path>, plugins: &[&str], command: &str) -> Outcome {
@ -339,7 +339,7 @@ pub fn nu_with_plugin_run_test(cwd: impl AsRef<Path>, plugins: &[&str], command:
println!("=== stderr\n{}", err);
Outcome::new(out, err.into_owned())
Outcome::new(out, err.into_owned(), output.status)
}
fn escape_quote_string(input: String) -> String {