forked from extern/nushell
Removes unnecessary cwd and pipeline from various tests (#9202)
# Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Cleans up various tests that unnecessarily use the `cwd` argument of `nu!`, and the `pipeline` function for single line commands. Also replaces some unnecessary raw strings with normal strings. Part of #8670. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> None # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> All checks pass # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -68,13 +68,12 @@ fn gets_first_row_when_no_amount_given() {
|
||||
|
||||
#[test]
|
||||
fn gets_first_row_as_list_when_amount_given() {
|
||||
let actual = nu!(
|
||||
cwd: ".", pipeline(
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
[1, 2, 3]
|
||||
| first 1
|
||||
| describe
|
||||
"#
|
||||
[1, 2, 3]
|
||||
| first 1
|
||||
| describe
|
||||
"#
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "list<int> (stream)");
|
||||
@ -83,24 +82,18 @@ fn gets_first_row_as_list_when_amount_given() {
|
||||
#[test]
|
||||
// covers a situation where `first` used to behave strangely on list<binary> input
|
||||
fn works_with_binary_list() {
|
||||
let actual = nu!(
|
||||
cwd: ".", pipeline(
|
||||
r#"
|
||||
([0x[01 11]] | first) == 0x[01 11]
|
||||
"#
|
||||
));
|
||||
let actual = nu!("([0x[01 11]] | first) == 0x[01 11]");
|
||||
|
||||
assert_eq!(actual.out, "true");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn errors_on_negative_rows() {
|
||||
let actual = nu!(
|
||||
cwd: ".", pipeline(
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
[1, 2, 3]
|
||||
| first -10
|
||||
"#
|
||||
[1, 2, 3]
|
||||
| first -10
|
||||
"#
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("use a positive value"));
|
||||
|
Reference in New Issue
Block a user