From b19a7aa8a62cedfb6240ebbd509197900cef16a2 Mon Sep 17 00:00:00 2001
From: ammkrn <46387933+ammkrn@users.noreply.github.com>
Date: Fri, 9 Apr 2021 21:01:21 -0500
Subject: [PATCH] Disallow rm to trash if built without trash-support enabled.
 (#3278)

If built without `trash_support`, nu should explicitly reject attempts to use `rm` with the `--trash` option, or with a config file which includes `rm_always_trash = true`.

As of 42fac72, there doesn't seem to be any guard in the `#[cfg(not(feature = "trash-support"))]` block of `filesystem_shell::rm`, leading to the behavior described in #3116, where builds without the trash-support feature will delete things permanently regardless of flags/config options.

This should close #3116
---
 .../src/filesystem/filesystem_shell.rs        | 26 ++++++++++++++++---
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/crates/nu-engine/src/filesystem/filesystem_shell.rs b/crates/nu-engine/src/filesystem/filesystem_shell.rs
index b7320826a..f243261ef 100644
--- a/crates/nu-engine/src/filesystem/filesystem_shell.rs
+++ b/crates/nu-engine/src/filesystem/filesystem_shell.rs
@@ -598,6 +598,28 @@ impl Shell for FilesystemShell {
         name: Tag,
         path: &str,
     ) -> Result<OutputStream, ShellError> {
+        let rm_always_trash = nu_data::config::config(Tag::unknown())?
+            .get("rm_always_trash")
+            .map(|val| val.is_true())
+            .unwrap_or(false);
+
+        #[cfg(not(feature = "trash-support"))]
+        {
+            if rm_always_trash {
+                return Err(ShellError::untagged_runtime_error(
+                    "Cannot execute `rm`; the current configuration specifies \
+                    `rm_always_trash = true`, but the current nu executable was not \
+                    built with feature `trash_support`.",
+                ));
+            } else if _trash.item {
+                return Err(ShellError::labeled_error(
+                    "Cannot execute `rm` with option `--trash`; feature `trash-support` not enabled",
+                    "this option is only available if nu is built with the `trash-support` feature",
+                    _trash.tag
+                ));
+            }
+        }
+
         let name_tag = name;
 
         if targets.is_empty() {
@@ -691,10 +713,6 @@ impl Shell for FilesystemShell {
                         let result;
                         #[cfg(feature = "trash-support")]
                         {
-                            let rm_always_trash = nu_data::config::config(Tag::unknown())?
-                                .get("rm_always_trash")
-                                .map(|val| val.is_true())
-                                .unwrap_or(false);
                             result = if _trash.item || (rm_always_trash && !_permanent.item) {
                                 trash::delete(&f).map_err(|e: trash::Error| {
                                     Error::new(ErrorKind::Other, format!("{:?}", e))