forked from extern/nushell
nu-table/ Do footer_inheritance by accouting for rows rather then a f… (#14380)
So it's my take on the comments in #14060
The change could be seen in this test.
Looks like it works :) but I haven't done a lot of testing.
0b1af77415/crates/nu-command/tests/commands/table.rs (L3032-L3062)
```nushell
$env.config.table.footer_inheritance = true;
$env.config.footer_mode = 7;
[[a b]; ['kv' {0: [[field]; [0] [1] [2] [3] [4] [5]]} ], ['data' 0], ['data' 0] ] | table --expand --width=80
```
```text
╭───┬──────┬───────────────────────╮
│ # │ a │ b │
├───┼──────┼───────────────────────┤
│ 0 │ kv │ ╭───┬───────────────╮ │
│ │ │ │ │ ╭───┬───────╮ │ │
│ │ │ │ 0 │ │ # │ field │ │ │
│ │ │ │ │ ├───┼───────┤ │ │
│ │ │ │ │ │ 0 │ 0 │ │ │
│ │ │ │ │ │ 1 │ 1 │ │ │
│ │ │ │ │ │ 2 │ 2 │ │ │
│ │ │ │ │ │ 3 │ 3 │ │ │
│ │ │ │ │ │ 4 │ 4 │ │ │
│ │ │ │ │ │ 5 │ 5 │ │ │
│ │ │ │ │ ╰───┴───────╯ │ │
│ │ │ ╰───┴───────────────╯ │
│ 1 │ data │ 0 │
│ 2 │ data │ 0 │
├───┼──────┼───────────────────────┤
│ # │ a │ b │
╰───┴──────┴───────────────────────╯
```
Maybe it will also solve the issue you @fdncred encountered.
close #14060
cc: @NotTheDr01ds
This commit is contained in:
@ -18,8 +18,12 @@ pub fn create_nu_table_config(
|
||||
expand: bool,
|
||||
mode: TableMode,
|
||||
) -> NuTableConfig {
|
||||
let with_footer = (config.table.footer_inheritance && out.with_footer)
|
||||
|| with_footer(config, out.with_header, out.table.count_rows());
|
||||
let mut count_rows = out.table.count_rows();
|
||||
if config.table.footer_inheritance {
|
||||
count_rows = out.count_rows;
|
||||
}
|
||||
|
||||
let with_footer = with_footer(config, out.with_header, count_rows);
|
||||
|
||||
NuTableConfig {
|
||||
theme: load_theme(mode),
|
||||
|
Reference in New Issue
Block a user