holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set env in exec command (#8917)

Browse Source 
# Description

Previously variables with `let-env` were not available after doing an
`exec` command. This PR fixes that

# User-Facing Changes

Can now use environment variables set with nushell after `exec`

# Tests + Formatting

No tests made but formatting has been checked

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->

Co-authored-by: Jelle Besseling <jelle@bigbridge.nl>
This commit is contained in:
Jelle Besseling 2023-04-20 12:10:46 +02:00 committed by GitHub
parent d42c2b2dbc
commit c8f54476c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/nu-command/src/system/exec.rs
View File

@ -81,6 +81,7 @@ fn exec(
let cwd = current_dir(engine_state, stack)?; let cwd = current_dir(engine_state, stack)?;
let mut command = external_command.spawn_simple_command(&cwd.to_string_lossy())?; let mut command = external_command.spawn_simple_command(&cwd.to_string_lossy())?;
command.current_dir(cwd); command.current_dir(cwd);
command.envs(&external_command.env_vars);
let err = command.exec(); // this replaces our process, should not return let err = command.exec(); // this replaces our process, should not return

2
crates/nu-command/src/system/run_external.rs
View File

@ -548,7 +548,7 @@ impl ExternalCommand {
} }
} }
fn create_process( pub fn create_process(
&self, &self,
input: &PipelineData, input: &PipelineData,
use_cmd: bool, use_cmd: bool,