forked from extern/nushell
Plugin api docs (#9452)
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Added comments to support API docs for the `nu-plugin` crate. Removed a few items that I'd expect should only be used internally to Nushell from the documentation and reduced the visibility of some items that did not need to be public. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> There should be no user facing impact. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> Standard tests run. Additionally numerous doctests were added to the `nu-plugin` crate. # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> No changes to the website necessary.
This commit is contained in:
@ -5,7 +5,7 @@ use serde::Serialize;
|
||||
use crate::engine::Command;
|
||||
use crate::{BlockId, Category, Flag, PositionalArg, SyntaxShape, Type};
|
||||
|
||||
/// A simple wrapper for Signature, includes examples.
|
||||
/// A simple wrapper for Signature that includes examples.
|
||||
#[derive(Clone, Serialize, Deserialize)]
|
||||
pub struct PluginSignature {
|
||||
pub sig: Signature,
|
||||
@ -23,13 +23,13 @@ impl PluginSignature {
|
||||
Self { sig, examples }
|
||||
}
|
||||
|
||||
// Add a default help option to a signature
|
||||
/// Add a default help option to a signature
|
||||
pub fn add_help(mut self) -> PluginSignature {
|
||||
self.sig = self.sig.add_help();
|
||||
self
|
||||
}
|
||||
|
||||
// Build an internal signature with default help option
|
||||
/// Build an internal signature with default help option
|
||||
pub fn build(name: impl Into<String>) -> PluginSignature {
|
||||
let sig = Signature::new(name.into()).add_help();
|
||||
Self::new(sig, vec![])
|
||||
@ -94,7 +94,6 @@ impl PluginSignature {
|
||||
desc: impl Into<String>,
|
||||
) -> PluginSignature {
|
||||
self.sig = self.sig.rest(name, shape, desc);
|
||||
|
||||
self
|
||||
}
|
||||
|
||||
@ -112,7 +111,6 @@ impl PluginSignature {
|
||||
short: Option<char>,
|
||||
) -> PluginSignature {
|
||||
self.sig = self.sig.named(name, shape, desc, short);
|
||||
|
||||
self
|
||||
}
|
||||
|
||||
@ -165,7 +163,6 @@ impl PluginSignature {
|
||||
/// Changes the signature category
|
||||
pub fn category(mut self, category: Category) -> PluginSignature {
|
||||
self.sig = self.sig.category(category);
|
||||
|
||||
self
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user