holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #317 from jonathandturner/fix_Add

Browse Source 
Fix adding at shallow depth
This commit is contained in:
Jonathan Turner 2019-08-20 16:09:12 +12:00 committed by GitHub
commit db125b4318
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/object/base.rs
View File

@ -354,7 +354,16 @@ impl Value {
if let Value::Object(ref mut o) = new_obj {
let mut current = o;
for idx in 0..split_path.len() - 1 {
if split_path.len() == 1 {
// Special case for inserting at the top level
current
.entries
.insert(path.to_string(), Tagged::from_item(new_value, tag));
return Some(Tagged::from_item(new_obj, tag));
}
for idx in 0..split_path.len() {
match current.entries.get_mut(split_path[idx]) {
Some(next) => {
if idx == (split_path.len() - 2) {

7
src/plugins/add.rs
View File

@ -23,9 +23,10 @@ impl Add {
Some(f) => match obj.insert_data_at_path(value_tag, &f, v) {
Some(v) => return Ok(v),
None => {
return Err(ShellError::string(
"add could not find place to insert field",
))
return Err(ShellError::string(format!(
"add could not find place to insert field {:?} {}",
obj, f
)))
}
},
None => Err(ShellError::string(