From e16c1b7c888fc8bcad30e1b4b7e0a6a779308cd7 Mon Sep 17 00:00:00 2001 From: Woohyun Lim <64784258+wolimst@users.noreply.github.com> Date: Sat, 24 Jun 2023 04:53:59 +0900 Subject: [PATCH] Revert install context of windows terminal profile to per-system (#9514) # Description Revert installation context of windows terminal profile to per-system, since installation context of other features are per-system, and having different installation context creates unnecessary inconsistency. Installation context change of windows terminal profile to per-user (#9322) was made to resolve the recent installer verification failure on winget submission PRs, but the cause of this problem seems to be in another place (#9513). For more details, refer discussions in #5812 and #9322. # User-Facing Changes Windows terminal profile for nushell will be installed in system context. Installation path will be changed as below: - before: `C:\Users\\AppData\Local\Microsoft\Windows Terminal\Fragments\nu\nu.json` - to: `C:\ProgramData\Microsoft\Windows Terminal\Fragments\nu\nu.json` # Tests + Formatting Confirmed successful installation of nushell and windows terminal profile file in windows using below installer that created by release ci workflow. It also contains changes made in #9513. Release ci workflow: https://github.com/wolimst/nushell/actions/runs/5357440849 Installer: https://github.com/wolimst/nushell/releases/tag/0.81.0-test --- wix/main.wxs | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/wix/main.wxs b/wix/main.wxs index d3874a499..e914a4fa5 100644 --- a/wix/main.wxs +++ b/wix/main.wxs @@ -285,25 +285,18 @@ - + - + - - - - - - - + KeyPath='yes'/> @@ -390,7 +383,7 @@ DllEntry="CAQuietExec" Execute="deferred" Return="check" - Impersonate="yes"/> + Impersonate="no"/>