Apply nightly clippy fixes (#11083)

<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx

you can also mention related issues, PRs or discussions!
-->

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
Clippy fixes for rust 1.76.0-nightly

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

N/A
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
This commit is contained in:
nibon7
2023-11-17 23:15:55 +08:00
committed by GitHub
parent 5063e01c12
commit f41c93b2d3
25 changed files with 57 additions and 58 deletions

View File

@ -70,13 +70,13 @@ pub const UNALIASABLE_PARSER_KEYWORDS: &[&[u8]] = &[
/// Check whether spans start with a parser keyword that can be aliased
pub fn is_unaliasable_parser_keyword(working_set: &StateWorkingSet, spans: &[Span]) -> bool {
// try two words
if let (Some(span1), Some(span2)) = (spans.get(0), spans.get(1)) {
if let (Some(span1), Some(span2)) = (spans.first(), spans.get(1)) {
let cmd_name = working_set.get_span_contents(span(&[*span1, *span2]));
return UNALIASABLE_PARSER_KEYWORDS.contains(&cmd_name);
}
// try one word
if let Some(span1) = spans.get(0) {
if let Some(span1) = spans.first() {
let cmd_name = working_set.get_span_contents(*span1);
UNALIASABLE_PARSER_KEYWORDS.contains(&cmd_name)
} else {
@ -653,7 +653,7 @@ pub fn parse_extern(
let (command_spans, rest_spans) = spans.split_at(split_id);
if let Some(name_span) = rest_spans.get(0) {
if let Some(name_span) = rest_spans.first() {
if let Some(err) = detect_params_in_name(
working_set,
*name_span,
@ -1135,7 +1135,7 @@ pub fn parse_export_in_module(
) -> (Pipeline, Vec<Exportable>) {
let spans = &lite_command.parts[..];
let export_span = if let Some(sp) = spans.get(0) {
let export_span = if let Some(sp) = spans.first() {
if working_set.get_span_contents(*sp) != b"export" {
working_set.error(ParseError::UnknownState(
"expected export statement".into(),
@ -1209,7 +1209,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref def_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = def_call.clone();
@ -1249,7 +1249,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref def_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = def_call.clone();
@ -1310,7 +1310,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref def_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = def_call.clone();
@ -1370,7 +1370,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref alias_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = alias_call.clone();
@ -1429,7 +1429,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref use_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = use_call.clone();
@ -1466,7 +1466,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref module_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = module_call.clone();
@ -1523,7 +1523,7 @@ pub fn parse_export_in_module(
expr: Expr::Call(ref def_call),
..
},
)) = pipeline.elements.get(0)
)) = pipeline.elements.first()
{
call = def_call.clone();

View File

@ -1572,10 +1572,10 @@ pub fn parse_brace_expr(
let (tokens, _) = lex(bytes, span.start + 1, &[b'\r', b'\n', b'\t'], &[b':'], true);
let second_token = tokens
.get(0)
.first()
.map(|token| working_set.get_span_contents(token.span));
let second_token_contents = tokens.get(0).map(|token| token.contents);
let second_token_contents = tokens.first().map(|token| token.contents);
let third_token = tokens
.get(1)
@ -2666,7 +2666,7 @@ pub fn parse_string_strict(working_set: &mut StateWorkingSet, span: Span) -> Exp
}
pub fn parse_import_pattern(working_set: &mut StateWorkingSet, spans: &[Span]) -> Expression {
let Some(head_span) = spans.get(0) else {
let Some(head_span) = spans.first() else {
working_set.error(ParseError::WrongImportPattern(
"needs at least one component of import pattern".to_string(),
span(spans),