Maxim Zhiburt
8d8b011702
Bump tabled dependency to 0.11 ( #8922 )
...
close? #8060
Quite a bit of refactoring took place.
I believe a few improvements to collapse/expand were made.
I've tried to track any performance regressions and seems like it is
fine.
I've noticed something different now with default configuration path or
something in this regard?
So I might missed something while testing because of this.
Requires some oversight.
---------
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2023-04-26 13:56:10 -05:00
WindSoilder
9b35d59023
Update crossterm version to 0.26 ( #8623 )
...
# Description
This pr is a companion to https://github.com/nushell/reedline/pull/560
Fortunally, we don't need to change too much nushell code.
## Additional note about lscolor dependency
https://github.com/sharkdp/lscolors/pull/58~~
lscolor is using 0.26 for now
2023-04-14 22:14:57 +02:00
Maxim Zhiburt
8deecc0137
table --collapse dont do truncation return message instead ( #8172 )
...
Reverts #8042
I've just noticed that #8042 was merged, but I didn't addressed your
@fdncred last comment.
This PR reverts #8042 and returns a message in cases where we need
truncation/wrapping.
157b7e0b60/crates/nu-command/tests/commands/table.rs (L234-L240)
2023-02-22 18:35:45 +00:00
Artemiy
e389e51b2b
Display empty records and lists ( #7925 )
...
# Description
Fix some issues related to #7444
1. Empty lists and records are now displayed as a small notice in a box:
2. Empty records are now correctly displayed if inside of another record
list or table:
3. Fixed inconsistent coloring of empty list placeholder inside of
lists/tables:
# User-Facing Changes
`table` command now displays empty records and lists like a table with
text and correctly displays empty records inside tables and lists.
New behavior of displaying empty lists and records can be disabled using
`table.show_empty` config option.
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io ) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-02-22 16:18:33 +00:00
Maxim Zhiburt
daeb3e5187
nu-table/ table --collapse style fix ( #8041 )
...
close #8033
So as I said they suppose to be there;
I've basically added a change of style if --collapse is used.
PS: I guess it's worth to add tests so hold on if you'll plan to merge
it.
---------
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2023-02-16 19:32:07 +00:00
Maxim Zhiburt
ccbdc9f6d8
nu-table/ Fix table --expand issue when table with no header involved ( #8045 )
...
close #8029
---------
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2023-02-12 23:28:42 +00:00
Stefan Holderbach
cfd2cc4970
Minor clippy: inline format string ( #8043 )
...
# Description
Clippy from nightly being pedantic
2023-02-11 17:47:08 +00:00
Maxim Zhiburt
6e6ef862c5
Address #7997 ( #8000 )
...
Hi there,
The case which was presented must be addressed.
But I did not test it properly...
I'd encourage you to do so.
Take care.
---------
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2023-02-07 20:01:31 -06:00
Maxim Zhiburt
731f5f8523
nu-commands/table (table -e) Recognize limited space better ( #7861 )
...
fix #7858
Once again we here 😞
~~I am thinking is there some files with not flat structure we could use
to test table -e?
I mean it is clear it was a while ago were we had to create at least
some tests.
Do you have anything in mind (or maybe commands which is consistent
across systems)?~~
Take care
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2023-01-26 14:06:17 -06:00
Anton
7221eb7f39
Fix typos and use more idiomatic assertions ( #7755 )
...
I have changed `assert!(a == b)` calls to `assert_eq!(a, b)`, which give
better error messages. Similarly for `assert!(a != b)` and
`assert_ne!(a, b)`. Basically all instances were comparing primitives
(string slices or integers), so there is no loss of generality from
special-case macros,
I have also fixed a number of typos in comments, variable names, and a
few user-facing messages.
2023-01-15 15:03:32 +13:00
Maxim Zhiburt
080874df10
Fix #7486 ( #7487 )
...
close #7486
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2022-12-15 09:55:15 -08:00
Maxim Zhiburt
33aea56ccd
Try to fix #7380 ( #7446 )
...
fix https://github.com/nushell/nushell/issues/7380
2022-12-15 08:47:04 -06:00
Maxim Zhiburt
41178dff90
Try to fix #7338 ( #7343 )
...
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2022-12-04 17:47:46 -06:00
Maxim Zhiburt
02ad491dea
[WIP] table: Change Record view in expand-mode ( #6885 )
...
* table: Change Record view in expand-mode
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix width issue
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Remove debug println!
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Update logic
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Improve the logic via a wrapping
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* `table -e` spread table to the whole width
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* fix CI
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fixing tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix coloring issues
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Don't expand when can
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Change the logic
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix cargo fmt
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2022-11-16 08:03:56 -06:00
Maxim Zhiburt
46c0d29c08
table/ Fix paging indexing ( #6850 )
...
* table/ Fix paging indexing
close #6840
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add test for pagging with row_overlapping
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2022-10-21 18:02:25 +02:00
JT
9ef65dcd69
Bump to 0.70 ( #6800 )
2022-10-19 07:13:36 +13:00
WindSoilder
1998bce19f
avoid freeze for table print ( #6688 )
...
* avoid freeze for table print
* make failed_with_proper_exit_code work again
* add test case for table
* fix un-used import on windows
2022-10-10 07:32:55 -05:00
Maxim Zhiburt
5921c19bc0
WIP/ Checkout to new tabled ( #6286 )
...
* nu-table/ Use latest tabled
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table/ Fix first column alignment
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Fix cargo clippy
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Fix color issue
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Fix footer row
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Bump tabled
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Bump tabled
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Bump tabled
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Update
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table/ Update
* Use latest tabled
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add optional -e, -c argument to `table` command for different view
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix clippy
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix clippy
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Update
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix cargo clippy
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* nu-table: Add footer into -e/c mode
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Publish new expand mode
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add width ctrl for Expand mode
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Refactorings
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Refactorings
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Merge with main
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix clippy
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix tests
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Bump tabled
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add record expand and fix empty list issue
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* refactoring
Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
2022-10-03 11:40:16 -05:00
