2 Commits

Author	SHA1	Message	Date
Gurpreet Singh	15a15c123e	Add a check for empty params for url join (#9356) ... # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Fix for #9347 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - [x] Add unit tests - [x] Run all cargo tests + fmt commands # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->	2023-06-07 19:08:21 +02:00
Vincenzo Carlino	8d5165c449	Feat/7725 url join (#7823) ... # Description Added command: `url join`. Closes: #7725 # User-Facing Changes ``` Converts a record to url Search terms: scheme, username, password, hostname, port, path, query, fragment Usage: > url join Flags: -h, --help - Display the help message for this command Signatures: <record> | url join -> <string> Examples: Outputs a url representing the contents of this record > { "scheme": "http", "username": "", "password": "", "host": "www.pixiv.net", "port": "", "path": "/member_illust.php", "query": "mode=medium&illust_id=99260204", "fragment": "", "params": { "mode": "medium", "illust_id": "99260204" } } | url join Outputs a url representing the contents of this record > { "scheme": "http", "username": "user", "password": "pwd", "host": "www.pixiv.net", "port": "1234", "query": "test=a", "fragment": "" } | url join Outputs a url representing the contents of this record > { "scheme": "http", "host": "www.pixiv.net", "port": "1234", "path": "user", "fragment": "frag" } | url join ``` # Questions - Which parameters should be required? Currenlty are: `scheme` and `host`.	2023-01-22 19:49:40 +01:00