nushell

holm/nushell

Fork 0

forked from extern/nushell

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Reilly Wood	80463d12fb	Revert "Primitives now use color closures..." (#7710 ) This temporarily reverts commit `c5639cd9fa` (PR https://github.com/nushell/nushell/pull/7650). See [here](https://github.com/nushell/nushell/pull/7650#issuecomment-1375036213) for details; the PR is accidentally adding ANSI escape codes to strings piped to externals. I think we should revert the PR because we're only 1-2 days away from a release; reverting it will give us more time to land+test a proper fix in the next release cycle.	2023-01-08 21:53:52 -08:00
Leon	c5639cd9fa	Primitives now use color closures when printed on the command line (#7650 ) # Description Closes #7554 ![image](https://user-images.githubusercontent.com/83939/210177700-4890fcf2-1be9-4da9-9974-58d4ed403430.png) # User-Facing Changes See above. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. Co-authored-by: Reilly Wood <26268125+rgwood@users.noreply.github.com>	2023-01-03 23:59:10 -08:00
Andrés N. Robalino	1c941557c3	Remove unused help shell. Slight cleanup and improvement. (#3258 )	2021-04-03 18:56:46 -05:00

Reilly Wood

80463d12fb

Revert "Primitives now use color closures..." (#7710 )

This temporarily reverts commit c5639cd9fa
(PR https://github.com/nushell/nushell/pull/7650). See
[here](https://github.com/nushell/nushell/pull/7650#issuecomment-1375036213)
for details; the PR is accidentally adding ANSI escape codes to strings
piped to externals.

I think we should revert the PR because we're only 1-2 days away from a
release; reverting it will give us more time to land+test a proper fix
in the next release cycle.

2023-01-08 21:53:52 -08:00

Leon

c5639cd9fa

Primitives now use color closures when printed on the command line (#7650 )

# Description

Closes #7554


![image](https://user-images.githubusercontent.com/83939/210177700-4890fcf2-1be9-4da9-9974-58d4ed403430.png)

# User-Facing Changes

See above.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.

Co-authored-by: Reilly Wood <26268125+rgwood@users.noreply.github.com>

2023-01-03 23:59:10 -08:00

Andrés N. Robalino

1c941557c3

Remove unused help shell. Slight cleanup and improvement. (#3258 )

2021-04-03 18:56:46 -05:00

3 Commits