forked from extern/nushell
01d8961eb7
# Description as we can see in the [documentation of `str.to_lowercase`](https://doc.rust-lang.org/std/primitive.str.html#method.to_lowercase), not only ASCII symbols have lower and upper variants. - `str upcase` uses the correct method to convert the string7ac5a01e2f/crates/nu-command/src/strings/str_/case/upcase.rs (L93)- `str downcase` incorrectly converts only ASCII characters7ac5a01e2f/crates/nu-command/src/strings/str_/case/downcase.rs (L124)this PR uses `str.to_lower_case` instead of `str.to_ascii_lowercase` in `str downcase`. # User-Facing Changes - upcase still works fine ```nushell ~ l> "ὀδυσσεύς" | str upcase ὈΔΥΣΣΕΎΣ ``` - downcase now works 👉 before ```nushell ~ l> "ὈΔΥΣΣΕΎΣ" | str downcase ὈΔΥΣΣΕΎΣ ``` 👉 after ```nushell ~ l> "ὈΔΥΣΣΕΎΣ" | str downcase ὀδυσσεύς ``` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - ⚫ `toolkit test` - ⚫ `toolkit test stdlib` adds two tests - `non_ascii_upcase` - `non_ascii_downcase` # After Submitting
Nushell core libraries and plugins
These sub-crates form both the foundation for Nu and a set of plugins which extend Nu with additional functionality.
Foundational libraries are split into two kinds of crates:
- Core crates - those crates that work together to build the Nushell language engine
- Support crates - a set of crates that support the engine with additional features like JSON support, ANSI support, and more.
Plugins are likewise also split into two types:
- Core plugins - plugins that provide part of the default experience of Nu, including access to the system properties, processes, and web-connectivity features.
- Extra plugins - these plugins run a wide range of different capabilities like working with different file types, charting, viewing binary data, and more.