holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity
05ff7a9925
nushell/crates
History
Antoine Stevan 05ff7a9925
FIX: do not allow *start > end* in error make spans (#8570) 
This should close #8567.

# Description
this PR throws an error when `start > end` in the most complete branch
of `ErrorMake::run`, i.e. when `$.msg`, `$.label.text`, `$.label.start`
and `$.label.end` are defined.

i've also added a `error_start_bigger_than_end_should_fail` test to
check that it does indeed return the right error.

# User-Facing Changes
no more crash when manipulating span bounds and a clear error, e.g.
```bash
>_ error make {msg: "msg" label: {text: "text" start: 1010 end: 1000}}
Error:
  × invalid error format.
   ╭─[entry #3:1:1]
 1 │ error make {msg: "msg" label: {text: "text" start: 1010 end: 1000}}
   ·                               ──────────────────┬─────────────────
   ·                                                 ╰── `$.label.start` is stricly bigger than `$.label.end`
   ╰────
  help: 1010 > 1000
```
or
```bash
>_ error make {
:::     msg: "msg"
:::     label: {
:::         text: "text"
:::         start: ($nu.scope.engine_state.source_bytes - 90)
:::         end: ($nu.scope.engine_state.source_bytes - 100)
:::     }
::: }
Error:
  × invalid error format.
   ╭─[entry #4:2:1]
 2 │         msg: "msg"
 3 │ ╭─▶     label: {
 4 │ │           text: "text"
 5 │ │           start: ($nu.scope.engine_state.source_bytes - 90)
 6 │ │           end: ($nu.scope.engine_state.source_bytes - 100)
 7 │ ├─▶     }
   · ╰──── `$.label.start` is stricly bigger than `$.label.end`
 8 │     }
   ╰────
  help: 204525 > 204515
```

# Tests + Formatting
- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🔴 `toolkit test`

# After Submitting
```
$nothing
```
2023-03-23 20:31:06 +01:00
..
nu_plugin_custom_values bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu_plugin_example bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu_plugin_formats bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu_plugin_gstat bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu_plugin_inc bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu_plugin_python update nu_plugin_python due to signature changes (#8107) 2023-02-18 13:27:24 +00:00
nu_plugin_query bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-cli fixes the ability to have multiple modifiers on keybindings (#8579) 2023-03-23 07:07:14 -05:00
nu-cmd-lang FIX: do not allow *start > end* in error make spans (#8570) 2023-03-23 20:31:06 +01:00
nu-color-config bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-command FIX: do not allow *start > end* in error make spans (#8570) 2023-03-23 20:31:06 +01:00
nu-engine Switch let/let-env family to init with math expressions (#8545) 2023-03-23 09:14:10 +13:00
nu-explore bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-glob bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-json bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-parser Disable alias recursion (for real) (#8557) 2023-03-22 23:16:06 +02:00
nu-path bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-plugin bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-pretty-hex bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-protocol Cell paths: make optional path members short-circuit (#8554) 2023-03-23 09:54:19 +13:00
nu-system bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-table bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-term-grid bump to 0.77.2 (#8496) 2023-03-17 21:29:15 +13:00
nu-test-support Remove once_cell dependency from nu-test-support create. (#8568) 2023-03-22 19:36:52 +01:00
nu-utils make std.nu tests work on mac (#8576) 2023-03-23 07:08:01 -05:00
README.md Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00

README.md

Nushell core libraries and plugins

These sub-crates form both the foundation for Nu and a set of plugins which extend Nu with additional functionality.

Foundational libraries are split into two kinds of crates:

  • Core crates - those crates that work together to build the Nushell language engine
  • Support crates - a set of crates that support the engine with additional features like JSON support, ANSI support, and more.

Plugins are likewise also split into two types:

  • Core plugins - plugins that provide part of the default experience of Nu, including access to the system properties, processes, and web-connectivity features.
  • Extra plugins - these plugins run a wide range of different capabilities like working with different file types, charting, viewing binary data, and more.