forked from extern/nushell
0bd4d27e8d
# Description The correction made here concerns the issue #8431. Indeed, the algorithm initially proposed to remove elements of a `vector` performed a loop with `remove` and an incident therefore appeared when several values were equal because the deletion was done outside the length of the vector: ```rust let mut found = false; for (i, col) in cols.clone().iter().enumerate() { if col == col_name { cols.remove(i); vals.remove(i); found = true; } } ``` Then, `[[a, a]; [1, 2]] | reject a: ` gave `thread 'main' panicked at 'removal index (is 1) should be < len (is 1)', crates/nu-protocol/src/value/mod.rs:1213:54`. The proposed correction is therefore the implementation of the `retain_mut` utility dedicated to this functionality. ```rust let mut found = false; let mut index = 0; cols.retain_mut(|col| { if col == col_name { found = true; vals.remove(index); false } else { index += 1; true } }); ```
150 lines
3.5 KiB
Rust
150 lines
3.5 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn regular_columns() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés Robalino 10/11/2013 A]
|
|
[Jonathan Turner 10/12/2013 B]
|
|
[Yehuda Katz 10/11/2013 A]
|
|
]
|
|
| reject type first_name
|
|
| columns
|
|
| str join ", "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "last_name, rusty_at");
|
|
}
|
|
|
|
#[test]
|
|
fn skip_cell_rejection() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"[ {a: 1, b: 2,c:txt}, { a:val } ] | reject a | get c.0"#));
|
|
|
|
assert_eq!(actual.out, "txt");
|
|
}
|
|
|
|
#[test]
|
|
fn complex_nested_columns() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
{
|
|
"nu": {
|
|
"committers": [
|
|
{"name": "Andrés N. Robalino"},
|
|
{"name": "Jonathan Turner"},
|
|
{"name": "Yehuda Katz"}
|
|
],
|
|
"releases": [
|
|
{"version": "0.2"}
|
|
{"version": "0.8"},
|
|
{"version": "0.9999999"}
|
|
],
|
|
"0xATYKARNU": [
|
|
["Th", "e", " "],
|
|
["BIG", " ", "UnO"],
|
|
["punto", "cero"]
|
|
]
|
|
}
|
|
}
|
|
| reject nu."0xATYKARNU" nu.committers
|
|
| get nu
|
|
| columns
|
|
| str join ", "
|
|
"#,
|
|
));
|
|
|
|
assert_eq!(actual.out, "releases");
|
|
}
|
|
|
|
#[test]
|
|
fn ignores_duplicate_columns_rejected() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
["first name", "last name"];
|
|
|
|
[Andrés Robalino]
|
|
[Andrés Jnth]
|
|
]
|
|
| reject "first name" "first name"
|
|
| columns
|
|
| str join ", "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "last name");
|
|
}
|
|
|
|
#[test]
|
|
fn reject_record_from_raw_eval() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
{"a": 3, "a": 4} | reject a | describe
|
|
"#
|
|
)
|
|
);
|
|
|
|
assert!(actual.out.contains("record"));
|
|
}
|
|
|
|
#[test]
|
|
fn reject_table_from_raw_eval() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[{"a": 3, "a": 4}] | reject a
|
|
"#
|
|
)
|
|
);
|
|
|
|
assert!(actual.out.contains("record 0 fields"));
|
|
}
|
|
|
|
#[test]
|
|
fn reject_nested_field() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
{a:{b:3,c:5}} | reject a.b | debug
|
|
"#
|
|
)
|
|
);
|
|
|
|
assert_eq!(actual.out, "{a: {c: 5}}");
|
|
}
|
|
|
|
#[test]
|
|
fn reject_two_identical_elements() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a, a]; [1, 2]] | reject a"#
|
|
)
|
|
);
|
|
assert!(actual.out.contains("record 0 fields"));
|
|
}
|
|
|
|
#[test]
|
|
fn reject_large_vec_with_two_identical_elements() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a, b, c, d, e, a]; [1323, 23, 45, 100, 2, 2423]] | reject a"#
|
|
)
|
|
);
|
|
assert!(!actual.out.contains("1323"));
|
|
assert!(!actual.out.contains("2423"));
|
|
assert!(actual.out.contains('b'));
|
|
assert!(actual.out.contains('c'));
|
|
assert!(actual.out.contains('d'));
|
|
assert!(actual.out.contains('e'));
|
|
assert!(actual.out.contains("23"));
|
|
assert!(actual.out.contains("45"));
|
|
assert!(actual.out.contains("100"));
|
|
assert!(actual.out.contains('2'));
|
|
}
|