Files
nushell/crates/nu-command/src/system/uname.rs
Ian Manske 9996e4a1f8 Shrink the size of Expr (#12610)
# Description
Continuing from #12568, this PR further reduces the size of `Expr` from
64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and
`Type` from 32 to 24 bytes.

This was accomplished by:
- for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`),
merging the fields into new AST struct types and then boxing this struct
(e.g. `Expr::Thing(Box<ABC>)`).
- replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and
`Expression`s should rarely be mutated, if at all, so this optimization
makes sense.

By reducing the size of these types, I didn't notice a large performance
improvement (at least compared to #12568). But this PR does reduce the
memory usage of nushell. My config is somewhat light so I only noticed a
difference of 1.4MiB (38.9MiB vs 37.5MiB).

---------

Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
2024-04-24 15:46:35 +00:00

101 lines
2.9 KiB
Rust

use nu_protocol::record;
use nu_protocol::Value;
use nu_protocol::{
ast::Call,
engine::{Command, EngineState, Stack},
Category, Example, PipelineData, ShellError, Signature, Type,
};
#[derive(Clone)]
pub struct UName;
impl Command for UName {
fn name(&self) -> &str {
"uname"
}
fn signature(&self) -> Signature {
Signature::build("uname")
.input_output_types(vec![(Type::Nothing, Type::table())])
.category(Category::System)
}
fn usage(&self) -> &str {
"Print certain system information using uutils/coreutils uname."
}
fn search_terms(&self) -> Vec<&str> {
// add other terms?
vec!["system", "coreutils"]
}
fn run(
&self,
_engine_state: &EngineState,
_stack: &mut Stack,
call: &Call,
_input: PipelineData,
) -> Result<PipelineData, ShellError> {
let span = call.head;
// Simulate `uname -all` is called every time
let opts = uu_uname::Options {
all: true,
kernel_name: false,
nodename: false,
kernel_release: false,
kernel_version: false,
machine: false,
processor: false,
hardware_platform: false,
os: false,
};
let output = uu_uname::UNameOutput::new(&opts).map_err(|e| ShellError::GenericError {
error: format!("{}", e),
msg: format!("{}", e),
span: None,
help: None,
inner: Vec::new(),
})?;
let outputs = [
output.kernel_name,
output.nodename,
output.kernel_release,
output.kernel_version,
output.machine,
output.os,
];
let outputs = outputs
.iter()
.map(|name| {
Ok(name
.as_ref()
.ok_or("unknown")
.map_err(|_| ShellError::NotFound { span })?
.to_string())
})
.collect::<Result<Vec<String>, ShellError>>()?;
Ok(PipelineData::Value(
Value::record(
record! {
"kernel-name" => Value::string(outputs[0].clone(), span),
"nodename" => Value::string(outputs[1].clone(), span),
"kernel-release" => Value::string(outputs[2].clone(), span),
"kernel-version" => Value::string(outputs[3].clone(), span),
"machine" => Value::string(outputs[4].clone(), span),
"operating-system" => Value::string(outputs[5].clone(), span),
},
span,
),
None,
))
}
fn examples(&self) -> Vec<Example> {
vec![Example {
description: "Print all information",
example: "uname",
result: None,
}]
}
}